1 Instead of having files foo.html "in front of" foo/, I prefer to have
2 foo/index.html. This patch allows that. Specifically, foo/index.type
3 is translated to $links{'foo/'}, and bestlink looks for either "foo" or
4 "foo/" when linking to pages. There are other miscellaneous changes that
7 1. change the `cgi_editpage` `@page_locs` code so that creating foo from
8 a/b/c prefers a/b/foo and then a/b/c/foo, but if creating foo from a/b/c/,
9 then prefer a/b/c/foo. I'm not really sure why the original was doing what
10 it did (why trim terminal `/` if no pages end in `/`?), so this part might
12 2. tweak things so that index.rss and index.atom are generated if inlining
14 2. backlinks from "foo/bar" to "foo/" trim common prefixes as long as there
15 would be something left when the trimming is done (i.e. don't trim "foo/")
16 3. parentlinks for "foo/" are the same as for "foo", except one directory
18 4. rewrite parentlinks so that bestlink is called at each level
19 5. basename("foo/") => basename("foo")
20 6. links to "foo/" are translated to "foo/index.html" rather than "foo/.html".
21 (Links to "foo/" might be preferred, but that causes an infinite loop in
22 writefile, because apparently dirname("foo/") == "foo/" on my system for
23 reasons that aren't clear to me.)
24 7. pagetitle("foo/") => pagetitle("foo")
25 8. clip the final slash when matching a relative pagespec, even if there are
26 no characters after it (otherwise inlining "./a" from "foo/" gets
27 translated to "foo//a")
29 In case whitespace gets garbled, I'm also leaving a copy of the patch on
30 [my site](http://ikidev.betacantrips.com/patches/index.patch). It should apply
31 cleanly to a freshly unpacked ikiwiki-1.42. You can also see it in action
32 [here](http://ikidev.betacantrips.com/one/). --Ethan
34 diff -urX ignorepats ikiclean/IkiWiki/CGI.pm ikidev/IkiWiki/CGI.pm
35 --- ikiclean/IkiWiki/CGI.pm 2007-02-11 21:40:32.419641000 -0800
36 +++ ikidev/IkiWiki/CGI.pm 2007-02-11 21:54:36.252357000 -0800
38 @page_locs=$best_loc=$page;
46 if ((defined $form->field('subpage') && length $form->field('subpage')) ||
47 $page eq gettext('discussion')) {
51 push @page_locs, $dir.$page;
52 - push @page_locs, "$from/$page";
53 + if ($dir ne $from){ # i.e. $from not a directory
54 + push @page_locs, "$from/$page";
58 push @page_locs, $dir.$page;
59 diff -urX ignorepats ikiclean/IkiWiki/Plugin/inline.pm ikidev/IkiWiki/Plugin/inline.pm
60 --- ikiclean/IkiWiki/Plugin/inline.pm 2007-02-11 21:40:31.996007000 -0800
61 +++ ikidev/IkiWiki/Plugin/inline.pm 2007-02-11 21:54:36.008358000 -0800
64 add_depends($params{page}, $params{pages});
66 - my $rssurl=rsspage(basename($params{page}));
67 - my $atomurl=atompage(basename($params{page}));
68 + my $rssurl=basename(rsspage($params{page}));
69 + my $atomurl=basename(atompage($params{page}));
72 if (exists $params{rootpage} && $config{cgiurl}) {
75 sub rsspage ($) { #{{{
77 + $page = htmlpage($page);
78 + $page =~s/\.html$/.rss/;
80 - return $page.".rss";
84 sub atompage ($) { #{{{
86 + $page = htmlpage($page);
87 + $page =~s/\.html$/.atom/;
89 - return $page.".atom";
93 sub genfeed ($$$$@) { #{{{
94 diff -urX ignorepats ikiclean/IkiWiki/Render.pm ikidev/IkiWiki/Render.pm
95 --- ikiclean/IkiWiki/Render.pm 2007-02-11 21:40:32.413641000 -0800
96 +++ ikidev/IkiWiki/Render.pm 2007-02-11 21:54:36.246356000 -0800
99 1 while (($dir)=$page_trimmed=~m!^([^/]+/)!) &&
101 + $p_trimmed=~m/^\Q$dir\E(?:.)/ &&
102 $p_trimmed=~s/^\Q$dir\E// &&
103 $page_trimmed=~s/^\Q$dir\E//;
108 return if $page eq 'index'; # toplevel
109 - foreach my $dir (reverse split("/", $page)) {
110 + if ($page =~ m{/$}){
115 + while ($page =~ m!([^/]+)$!) {
117 + $page =~ s!/?[^/]+$!!;
120 - unshift @ret, { url => $path.htmlpage($dir), page => pagetitle($dir) };
121 + my $target = abs2rel(htmlpage(bestlink($page, $last)), $page);
122 + unshift @ret, { url => $path.$target, page => pagetitle($last) };
126 diff -urX ignorepats ikiclean/IkiWiki.pm ikidev/IkiWiki.pm
127 --- ikiclean/IkiWiki.pm 2007-02-11 21:40:35.118406000 -0800
128 +++ ikidev/IkiWiki.pm 2007-02-11 22:22:49.146071000 -0800
130 sub basename ($) { #{{{
137 @@ -214,12 +215,14 @@
138 my $type=pagetype($file);
140 $page=~s/\Q.$type\E*$// if defined $type;
141 + $page=~s#index$## if $page=~m{/index$};
145 sub htmlpage ($) { #{{{
148 + return $page."index.html" if $page=~m{/$};
149 return $page.".html";
158 if ($link=~s/^\/+//) {
161 if (exists $links{$l}) {
164 + if (exists $links{$l.'/'}){
167 elsif (exists $pagecase{lc $l}) {
168 return $pagecase{lc $l};
171 $page=~s/__(\d+)__/&#$1;/g;
181 if ($glob =~ m!^\./!) {
182 - $from=~s!/?[^/]+$!!;
183 + $from=~s!/?[^/]*$!!;
185 $glob="$from/$glob" if length $from;
188 I independently implemented a similar, but smaller patch.
189 (It's smaller because I only care about rendering; not CGI, for example.)
190 The key to this patch is that "A/B/C" is treated as equivalent
192 Here it is: --Per Bothner
194 --- IkiWiki/Render.pm~ 2007-01-11 15:01:51.000000000 -0800
195 +++ IkiWiki/Render.pm 2007-02-02 22:24:12.000000000 -0800
197 foreach my $dir (reverse split("/", $page)) {
200 - unshift @ret, { url => $path.htmlpage($dir), page => pagetitle($dir) };
201 + unshift @ret, { url => abs2rel(htmlpage(bestlink($page, $dir)), dirname($page)), page => pagetitle($dir) };
204 + elsif ($dir ne "index") {
209 --- IkiWiki.pm~ 2007-01-12 12:47:09.000000000 -0800
210 +++ IkiWiki.pm 2007-02-02 18:02:16.000000000 -0800
212 elsif (exists $pagecase{lc $l}) {
213 return $pagecase{lc $l};
216 + my $lindex = $l . "/index";
217 + if (exists $links{$lindex}) {
221 } while $cwd=~s!/?[^/]+$!!;
223 if (length $config{userdir} && exists $links{"$config{userdir}/".lc($link)}) {
225 Note I handle setting the url; slightly differently.
226 Also note that an initial "index" is ignored. I.e. a
227 page "A/B/index.html" is treated as "A/B".
229 > This is actually a pretty cool hack. I'll have to think about
230 > whether I like it better than my way though :) --Ethan
234 How about doing the index stuff only on the output side? (Or does the latter patch do it? I haven't tried them.) That is, render every `foo.type` for the rendered types (mdwn etc.) as `foo/index.html`, generating links to `foo/` instead of `foo.html`, but not earlier than the point where the .html as presently appended to the page name. Then you just flip a build time option on an existing wiki without any changes to that, and the pages appear elsewhere. The `index.type` files might be left out of this scheme, though (and the top-level one, of course, has to). --[[tuomov]]
236 > Well, get around to wasting time on it after all, and [here's the patch](http://iki.fi/tuomov/use_dirs.diff). The `-use_dirs` option will cause everything to be rendered inside directories. There may still be some problems with it, that need looking into (it doesn't e.g. check for conflicts between foo/index.mdwn and foo.mdwn), but seems to work well enough for me... The patch also improves, I think, the parentlinks code a little, as it uses generic routines to actually find the target location now. The only places where the `use_dirs` option is used is `htmlpage`, in fact, although other specific kludges needed to be removed from other points in the code.
238 >> FWIW, [use_dirs.diff](http://iki.fi/tuomov/use_dirs.diff) applies cleanly, and works well for me. Given that it makes this behaviour optional, how about merging it? I have some follow-up patches which I'm sitting on for now. ;-) -- Ben
240 >>> How do you apply a patch created by svn diff? I've been curious about this for a long time. The use_dirs patch looks OK but I'd like to play with it. --Ethan
242 >>>> Just do `svn co svn://ikiwiki.kitenet.net/ikiwiki/trunk ikiwiki` then `cd ikiwiki && patch -p0 <use_dirs.diff`. :-) Same would work with a tarball as well.
247 First pass over Tumov's patch -- which doesn't cleanly apply anymore, so
248 I'll attach an updated and slightly modified version below.
250 * `urlto()` is O(N) to the number of pages in the wiki, which leads to
251 O(N^2) behavior, which could be a scalability problem. This happens because
252 of the lookup for `$to` in `%renderedfiles`, which shouldn't be necessary
253 most of the time. Couldn't it just be required that `$to` be a html page
254 name on input? Or require it be a non-html page name and always run
256 * As we discussed in email, this will break handling of `foo/index.mdwn`
257 pages. Needs to be changed to generate `foo/index/index.html` for such
258 pages (though not for the toplevel `index`).
259 * This does make the resulting wikis much less browsable directly on the
260 filesystem, since `dir` to `dir/index.html` conversion is only handled by web
261 servers and so you end up browsing to a directory index all the time.
262 Wouldn't it be better to make the links themselves include the index.html?
263 * Some of the generated links are missing the trailing / , which is
264 innefficient since it leads to a http redirect when clicking on that
265 link. Seems to be limited to ".." links, and possibly only to
266 parentlinks. (Already fixed it for "." links.)
267 * It calles abs2rel about 16% more often with the patch, which makes it
268 a bit slower, since abs2rel is not very efficient. (This omits abs2rel
269 calls that might be memoized away already.) This seems to be due to one
270 extra abs2rel for the toplevel wiki page due to the nicely cleaned up code
271 in `parentlinks` -- so I'm not really complaining.. Especially since the
272 patch adds a new nice memoizable `urlto`.
273 * The rss page name generation code seems unnecesarily roundabout, I'm sure
274 that can be cleaned up somehow, perhaps by making `htmlpage` more
276 * `aggregate.pm` uses htmlpage in a way that breaks with its new behavior.
277 It will need to be changed as follows:
281 ===================================================================
282 --- aggregate.pm (revision 2700)
283 +++ aggregate.pm (working copy)
285 # NB: This doesn't check for path length limits.
287 my $max=POSIX::pathconf($config{srcdir}, &POSIX::_PC_NAME_MAX);
288 - if (defined $max && length(htmlpage($page)) >= $max) {
289 + if (defined $max && length(htmlfn($page)) >= $max) {
291 $page=$feed->{dir}."/item";
292 while (exists $IkiWiki::pagecase{lc $page.$c} ||
294 if (ref $feed->{tags}) {
295 $template->param(tags => [map { tag => $_ }, @{$feed->{tags}}]);
297 - writefile(htmlpage($guid->{page}), $config{srcdir},
298 + writefile(htmlfn($guid->{page}), $config{srcdir},
301 # Set the mtime, this lets the build process get the right creation
303 return "$config{srcdir}/".htmlpage($page);
306 +sub htmlfn ($) { #{{{
307 + return shift().".html";
313 * `linkmap.pm` uses `htmlpage` to construct a link and should probably be
314 changed like this (untested):
318 ===================================================================
319 --- linkmap.pm (revision 2700)
320 +++ linkmap.pm (working copy)
322 foreach my $item (keys %links) {
323 if (pagespec_match($item, $params{pages}, $params{page})) {
324 my $link=htmlpage($item);
325 - $link=IkiWiki::abs2rel($link, IkiWiki::dirname($params{page}));
326 - $mapitems{$item}=$link;
327 + $mapitems{$item}=urlto($link, $params{destpage});
332 * `inline.pm` uses htmlpage and `abs2rel` to generate a link, and probably
333 needs to be changed to either use `urlto` or to call `beautify_url` like
334 htmllink does. This might work:
338 ===================================================================
339 --- inline.pm (revision 2700)
340 +++ inline.pm (working copy)
342 # Don't use htmllink because this way the
343 # title is separate and can be overridden by
345 - my $link=bestlink($params{page}, $page);
346 - $link=htmlpage($link) if defined $type;
347 - $link=abs2rel($link, dirname($params{destpage}));
348 - $template->param(pageurl => $link);
349 + $template->param(pageurl => urlto(bestlink($params{page}, $page), $params{destpage}));
350 $template->param(title => pagetitle(basename($page)));
351 $template->param(ctime => displaytime($pagectime{$page}));
354 * `img.pm` makes some assumptions about name of the page that will be
355 linking to the image, which are probably broken.
357 * The changes to htmlpage's behavior probably call for the plugin
358 interface version number to be changed.
362 Updated version of Tumov's patch follows:
365 Index: IkiWiki/Render.pm
366 ===================================================================
367 --- IkiWiki/Render.pm (revision 2700)
368 +++ IkiWiki/Render.pm (working copy)
371 return unless $backlinks{$page};
372 foreach my $p (keys %{$backlinks{$page}}) {
373 - my $href=abs2rel(htmlpage($p), dirname($page));
375 + my $href=urlto($p, $page);
377 # Trim common dir prefixes from both pages.
379 my $page_trimmed=$page;
385 + my $title=$config{wikiname};
387 return if $page eq 'index'; # toplevel
388 - foreach my $dir (reverse split("/", $page)) {
391 - unshift @ret, { url => $path.htmlpage($dir), page => pagetitle($dir) };
396 + foreach my $dir (split("/", $page)) {
397 + push @ret, { url => urlto($path, $page), page => $title };
399 + $title=pagetitle($dir);
401 - unshift @ret, { url => length $path ? $path : ".", page => $config{wikiname} };
405 Index: IkiWiki/Plugin/inline.pm
406 ===================================================================
407 --- IkiWiki/Plugin/inline.pm (revision 2700)
408 +++ IkiWiki/Plugin/inline.pm (working copy)
411 add_depends($params{page}, $params{pages});
413 - my $rssurl=rsspage(basename($params{page}));
414 - my $atomurl=atompage(basename($params{page}));
415 + my $rssurl=basename(rsspage($params{page}));
416 + my $atomurl=basename(atompage($params{page}));
419 if (exists $params{rootpage} && $config{cgiurl}) {
421 # title is separate and can be overridden by
423 my $link=bestlink($params{page}, $page);
424 - $link=htmlpage($link) if defined $type;
425 - $link=abs2rel($link, dirname($params{destpage}));
426 + $link=urlto($link, $params{destpage});
427 $template->param(pageurl => $link);
428 $template->param(title => pagetitle(basename($page)));
429 $template->param(ctime => displaytime($pagectime{$page}));
430 @@ -205,15 +204,17 @@
434 - will_render($params{page}, rsspage($params{page}));
435 - writefile(rsspage($params{page}), $config{destdir},
436 + my $rssp=rsspage($params{page});
437 + will_render($params{page}, $rssp);
438 + writefile($rssp, $config{destdir},
439 genfeed("rss", $rssurl, $desc, $params{page}, @list));
440 $toping{$params{page}}=1 unless $config{rebuild};
441 $feedlinks{$params{destpage}}=qq{<link rel="alternate" type="application/rss+xml" title="RSS" href="$rssurl" />};
444 - will_render($params{page}, atompage($params{page}));
445 - writefile(atompage($params{page}), $config{destdir},
446 + my $atomp=atompage($params{page});
447 + will_render($params{page}, $atomp);
448 + writefile($atomp, $config{destdir},
449 genfeed("atom", $atomurl, $desc, $params{page}, @list));
450 $toping{$params{page}}=1 unless $config{rebuild};
451 $feedlinks{$params{destpage}}=qq{<link rel="alternate" type="application/atom+xml" title="Atom" href="$atomurl" />};
452 @@ -288,16 +289,25 @@
456 +sub basepage ($) { #{{{
459 + $page=htmlpage($page);
460 + $page =~ s/\.html$//;
465 sub rsspage ($) { #{{{
468 - return $page.".rss";
469 + return basepage($page).".rss";
472 sub atompage ($) { #{{{
475 - return $page.".atom";
476 + return basepage($page).".atom";
479 sub genfeed ($$$$@) { #{{{
481 ===================================================================
482 --- ikiwiki.in (revision 2700)
483 +++ ikiwiki.in (working copy)
485 "sslcookie!" => \$config{sslcookie},
486 "httpauth!" => \$config{httpauth},
487 "userdir=s" => \$config{userdir},
488 + "usedirs!" => \$config{usedirs},
489 "exclude=s@" => sub {
490 push @{$config{wiki_file_prune_regexps}}, $_[1];
492 Index: doc/usage.mdwn
493 ===================================================================
494 --- doc/usage.mdwn (revision 2700)
495 +++ doc/usage.mdwn (working copy)
502 + Create output files named page/index.html instead of page.html.
504 * --w3mmode, --no-w3mmode
506 Enable [[w3mmode]], which allows w3m to use ikiwiki as a local CGI script,
507 Index: doc/plugins/write.mdwn
508 ===================================================================
509 --- doc/plugins/write.mdwn (revision 2700)
510 +++ doc/plugins/write.mdwn (working copy)
513 This is the standard gettext function, although slightly optimised.
517 +Construct a relative url to the first parameter from the second.
521 ikiwiki's support for revision control systems also uses pluggable perl
522 Index: doc/ikiwiki.setup
523 ===================================================================
524 --- doc/ikiwiki.setup (revision 2700)
525 +++ doc/ikiwiki.setup (working copy)
528 # To link to user pages in a subdirectory of the wiki.
530 + # To enable alternate output filenames.
533 # To add plugins, list them here.
534 #add_plugins => [qw{goodstuff openid search wikitext camelcase
536 ===================================================================
537 --- IkiWiki.pm (revision 2700)
538 +++ IkiWiki.pm (working copy)
540 use Exporter q{import};
541 our @EXPORT = qw(hook debug error template htmlpage add_depends pagespec_match
542 bestlink htmllink readfile writefile pagetype srcfile pagename
543 - displaytime will_render gettext
544 + displaytime will_render gettext urlto
545 %config %links %renderedfiles %pagesources);
546 our $VERSION = 1.02; # plugin interface version, next is ikiwiki version
547 our $version='unknown'; # VERSION_AUTOREPLACE done by Makefile, DNE
555 sub checkconfig () { #{{{
557 sub htmlpage ($) { #{{{
560 - return $page.".html";
561 + if (! $config{usedirs} || $page =~ /^index$/ || $page =~ /\/index$/) {
562 + return $page.".html";
564 + return $page."/index.html";
568 sub srcfile ($) { #{{{
571 return "$config{url}/" if ! defined $page;
573 + $page=htmlpage($page);
575 $page=~s/[^\/]+\//..\//g;
578 $config{timeformat}, localtime($time)));
581 +sub beautify_url ($) { #{{{
584 + $url =~ s!/index.html$!/!;
585 + $url =~ s!^$!./!; # Browsers don't like empty links...
590 +sub urlto ($$) { #{{{
595 + ! grep { $_ eq $to } map { @{$_} } values %renderedfiles) {
599 + my $link = abs2rel($to, dirname(htmlpage($from)));
601 + return beautify_url($link);
604 sub htmllink ($$$;@) { #{{{
605 my $lpage=shift; # the page doing the linking
606 my $page=shift; # the page that will contain the link (different for inline)
608 "\">?</a>$linktext</span>"
611 - $bestlink=abs2rel($bestlink, dirname($page));
612 + $bestlink=abs2rel($bestlink, dirname(htmlpage($page)));
613 + $bestlink=beautify_url($bestlink);
615 if (! $opts{noimageinline} && isinlinableimage($bestlink)) {
616 return "<img src=\"$bestlink\" alt=\"$linktext\" />";