[[!meta author="""http://kerravonsen.dreamwidth.org/"""]] [[!meta authorurl="""http://kerravonsen.dreamwidth.org/"""]] [[!meta title="""change to todo/Improving_the_efficiency_of_match__95__glob on ikiwiki"""]] [[!meta permalink="http://ikiwiki.info/recentchanges/#change-608cef54d63ba60efd24ae14012dda7ff8d014a9"]]

Changed pages: [[diff|wikiicons/diff.png]]todo/Improving the efficiency of match_glob
Changed by: kerravonsen [dreamwidth.org]
Commit type: web
Date: 22:01:21 11/14/10
[[revert|wikiicons/revert.png]]
theory about differences in speed of memoize and non-memoize patches
diff --git a/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn b/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn
index c4d3a8e..43571ea 100644
--- a/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn
+++ b/doc/todo/Improving_the_efficiency_of_match__95__glob.mdwn
@@ -20,6 +20,8 @@ Here's my patch - please consider it! -- [[KathrynAndersen]]
 >>>> is less verbose than Kathryn's patch but also not as
 >>>> fast; I'm not sure why, tbh. --[[smcv]]
 
+>>>>> I think it's because my patch focuses on match_glob while the memoize patch focuses on `glob2re`, and `glob2re` is called in `filecheck`, `meta` and `po` as well as in `match_glob` and `match_user`; thus the memoized `glob2re` is dealing with a bigger set of globs to look up, and thus could be just that little bit slower. -- [[KathrynAndersen]]
+
 --------------------------------------------------------------
 Benchmarks done with Devel::Profile on the same testbed IkiWiki setup.  I'm just showing the start of the profile output, since that's what's relevant.