add missing test to avoid uninitialised value when a page with metadata is removed

[ikiwiki.git] / IkiWiki / Render.pm

diff --git a/IkiWiki/Render.pm b/IkiWiki/Render.pm
index 02f6b4b1c1561e8a74784c8423d50e9053a66b8c..76e8ef1f4e7d0369eb6b48cc296436607037cfc6 100644 (file)
--- a/IkiWiki/Render.pm
+++ b/IkiWiki/Render.pm
@@ -85,8 +85,9 @@ sub genpage ($$) { #{{{
                $actions++;
        }
                
-       if ($config{rcs}) {
-               $template->param(recentchangesurl => urlto("recentchanges", $page));
+       if ($config{rcs} && exists $config{recentchangespage} &&
+           $page ne $config{recentchangespage}) {
+               $template->param(recentchangesurl => urlto($config{recentchangespage}, $page));
                $actions++;
        }
 
@@ -259,6 +260,8 @@ sub refresh () { #{{{
                        $test=dirname($test);
                }
        }
+       
+       run_hooks(refresh => sub { shift->() });
 
        # find existing pages
        my %exists;
@@ -317,15 +320,19 @@ sub refresh () { #{{{
                }, $dir);
        };
 
-       my %rendered;
+       my (%rendered, @add, @del, @internal);
 
        # check for added or removed pages
-       my @add;
        foreach my $file (@files) {
                my $page=pagename($file);
                $pagesources{$page}=$file;
                if (! $pagemtime{$page}) {
-                       push @add, $file;
+                       if (isinternal($page)) {
+                               push @internal, $file;
+                       }
+                       else {
+                               push @add, $file;
+                       }
                        $pagecase{lc $page}=$page;
                        if ($config{getctime} && -e "$config{srcdir}/$file") {
                                $pagectime{$page}=rcs_getctime("$config{srcdir}/$file");
@@ -335,11 +342,15 @@ sub refresh () { #{{{
                        }
                }
        }
-       my @del;
        foreach my $page (keys %pagemtime) {
                if (! $exists{$page}) {
-                       debug(sprintf(gettext("removing old page %s"), $page));
-                       push @del, $pagesources{$page};
+                       if (isinternal($page)) {
+                               push @internal, $pagesources{$page};
+                       }
+                       else {
+                               debug(sprintf(gettext("removing old page %s"), $page));
+                               push @del, $pagesources{$page};
+                       }
                        $links{$page}=[];
                        $renderedfiles{$page}=[];
                        $pagemtime{$page}=0;
@@ -364,7 +375,13 @@ sub refresh () { #{{{
                    $mtime > $pagemtime{$page} ||
                    $forcerebuild{$page}) {
                        $pagemtime{$page}=$mtime;
-                       push @needsbuild, $file;
+                       if (isinternal($page)) {
+                               push @internal, $file;
+                               scan($file);
+                       }
+                       else {
+                               push @needsbuild, $file;
+                       }
                }
        }
        run_hooks(needsbuild => sub { shift->(\@needsbuild) });
@@ -380,6 +397,15 @@ sub refresh () { #{{{
                render($file);
                $rendered{$file}=1;
        }
+       foreach my $file (@internal) {
+               # internal pages are not rendered
+               my $page=pagename($file);
+               delete $depends{$page};
+               foreach my $old (@{$renderedfiles{$page}}) {
+                       delete $destsources{$old};
+               }
+               $renderedfiles{$page}=[];
+       }
        
        # rebuild pages that link to added or removed pages
        if (@add || @del) {
@@ -395,13 +421,17 @@ sub refresh () { #{{{
                }
        }
 
-       if (%rendered || @del) {
+       if (%rendered || @del || @internal) {
+               my @changed=(keys %rendered, @del);
+
                # rebuild dependant pages
                foreach my $f (@files) {
                        next if $rendered{$f};
                        my $p=pagename($f);
                        if (exists $depends{$p}) {
-                               foreach my $file (keys %rendered, @del) {
+                               # only consider internal files
+                               # if the page explicitly depends on such files
+                               foreach my $file (@changed, $depends{$p}=~/internal\(/ ? @internal : ()) {
                                        next if $f eq $file;
                                        my $page=pagename($file);
                                        if (pagespec_match($page, $depends{$p}, location => $p)) {
@@ -417,7 +447,7 @@ sub refresh () { #{{{
                # handle backlinks; if a page has added/removed links,
                # update the pages it links to
                my %linkchanged;
-               foreach my $file (keys %rendered, @del) {
+               foreach my $file (@changed) {
                        my $page=pagename($file);
                        
                        if (exists $links{$page}) {
@@ -439,6 +469,7 @@ sub refresh () { #{{{
                                }
                        }
                }
+
                foreach my $link (keys %linkchanged) {
                        my $linkfile=$pagesources{$link};
                        if (defined $linkfile) {