Moved the postscan hook to run on the raw html of a page, before the template is...

[ikiwiki.git] / doc / bugs / Search_summary_includes_text_from_navigational_elements.mdwn

diff --git a/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn b/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn
index 874b9ffeb531749834af682f46d12c7d067e2f5c..b774c4531cbf4adab0252f101de36445bdf95526 100644 (file)
--- a/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn
+++ b/doc/bugs/Search_summary_includes_text_from_navigational_elements.mdwn
@@ -7,3 +7,16 @@ A way to name some CSS ids that should be removed in search results within the i
 http://leaf.dragonflybsd.org/mailarchive/users/2009-11/msg00077.html
 
 (bin attachment on that page is actually a .diff.)
 http://leaf.dragonflybsd.org/mailarchive/users/2009-11/msg00077.html
 
 (bin attachment on that page is actually a .diff.)

+
+> So I was looking at this and I relized that while the search plugin used
+> to use the format hook, and so there was no way to avoid it seeing all
+> the gunk around the page body, it was changed a while ago for different
+> reasons to use its own hook, postscan. So there's really no reason not
+> to move postscan so it runs before said gunk is added to the page.
+> (Aside from a small risk of breaking other third-party plugins that
+> somehow use postscan.)
+> 
+> I've implemented that in git, and it drops the navigation elements nicely.
+> It's perhaps less general than allowing specific divs to be skipped from
+> search, but it seems good enough. Please thank the dragonfly guys for their
+> work on this. [[done]] --[[Joey]]