]> sipb.mit.edu Git - ikiwiki.git/blobdiff - IkiWiki/Plugin/openid.pm
* Fix openid signin secret generation code. This fixes the bug that made
[ikiwiki.git] / IkiWiki / Plugin / openid.pm
index 7ea67c5ca4a34aeaac6f17d0fe23137878fb80e4..4a7255069928c7d2b3bafb23730f7ef4783462c1 100644 (file)
@@ -33,8 +33,8 @@ sub formbuilder_setup (@) { #{{{
                        label => "OpenID",
                        size => 30,
                        comment => '('.
-                               htmllink("", "", "OpenID", 1, 0, "What's this?")
-                               .($config{openidsignup} ? " | <a href=\"$config{openidsignup}\">Get an OpenID</a>" : "")
+                               htmllink("", "", "OpenID", 1, 0, gettext("What's this?"))
+                               .($config{openidsignup} ? " | <a href=\"$config{openidsignup}\">".gettext("Get an OpenID")."</a>" : "")
                                .')'
                );
 
@@ -56,6 +56,12 @@ sub formbuilder_setup (@) { #{{{
                        }
                }
        }
+       elsif ($form->title eq "preferences") {
+               if (! defined $form->field(name => "name")) {
+                       $form->field(name => "OpenID", disabled => 1, value =>
+                               $session->param("name"), size => 30, force => 1);
+               }
+       }
 }
 
 sub validate ($$$;$) { #{{{
@@ -134,13 +140,14 @@ sub getobj ($$) { #{{{
        # Store the secret in the session.
        my $secret=$session->param("openid_secret");
        if (! defined $secret) {
-               $secret=$session->param(openid_secret => time);
+               $secret=rand;
+               $session->param(openid_secret => $secret);
        }
 
        return Net::OpenID::Consumer->new(
                ua => $ua,
                args => $q,
-               consumer_secret => $secret,
+               consumer_secret => sub { return shift()+$secret },
                required_root => $config{cgiurl},
        );
 } #}}}