web commit by joey

[ikiwiki.git] / doc / security.mdwn

diff --git a/doc/security.mdwn b/doc/security.mdwn
index 252239331d30731a5c0fc750bd874e04114ced0a..ce4c6f718202581e3dc3871d8b4a64cead0c82b0 100644 (file)
--- a/doc/security.mdwn
+++ b/doc/security.mdwn
@@ -71,10 +71,12 @@ this wiki, BTW.
 
 ## svn commit logs
 
-Currently html is not escape in svn commit logs, this should probably be fixed.
-
 Anyone with svn commit access can forge "web commit from foo" and make it appeat on [[RecentChanges]] like foo committed. One way to avoid this would be to limit web commits to those done by a certian user.
 
+It's actually possible to force a whole series of svn commits to appear to have come just before yours, by forging svn log output. This could be guarded against somewhat by revision number scanning, since the forged revisions would duplicate the numbers of unforged ones. Or subversion could fix svn log to indent commit messages, which would make such forgery impossible..
+
+ikiwiki escapes any html in svn commit logs to prevent other mischief.
+
 ----
 
 # Hopefully non-holes
@@ -137,7 +139,7 @@ security holes breed. It needs a test suite at the very least.
 ## cgi password security
 
 Login to the wiki involves sending a password in cleartext over the net.
-Cracking the password only allows editing the moo as that user though.
+Cracking the password only allows editing the wiki as that user though.
 If you care, you can use https, I suppose.
 
 ## CGI::Session security