followups

[ikiwiki.git] / doc / plugins / po.mdwn

diff --git a/doc/plugins/po.mdwn b/doc/plugins/po.mdwn
index 9273da399a3207543802a6c4ca48bcc1d5924928..65573b8775ed488635cecbfd9d9110128357afa2 100644 (file)
--- a/doc/plugins/po.mdwn
+++ b/doc/plugins/po.mdwn
@@ -264,6 +264,11 @@ good reason for that to be done? --[[Joey]]
 
 > The commit 0113c69d4fb in my po branch might fix this. --[[intrigeri]]
 
+>> It may fix it in passing, but shouldn't it also be fixed for the other
+>> `po_link_to` styles? (Also, if `mybestlink` is going to always 
+>> just return `bestlink` in this case, there seems no reason to inject
+>> it.) --[[Joey]]
+
 Language display order
 ----------------------
 
@@ -289,6 +294,12 @@ that po might be replacing the only link on a page, in error?
 > be either good (better overall l10n) or bad (break the other
 > plugin's goal). --[[intrigeri]]
 
+>> Right.. well, the cases where links are added is very small.
+>> Grepping for `add_link`, it's just done by link, camelcase, meta, and
+>> tag. All of these are supposed to work just link regular links
+>> so I'd think that is ok. We could probably remove the currently scary
+>> comment about only wanting to change the first link. --[[Joey]] 
+
 Name of toplevel index page
 ---------------------------
 
@@ -300,6 +311,14 @@ like "index.da". --[[Joey]]
 > test with a predicate call such as isindexpage($page). Such a predicate
 > function could then be overriden by the po plugin. --[[intrigeri]]
 
+>> Could do that, but if you have such a function it's natural to want to
+>> use it elsewhere. Not clear to me it would make sense for po to override
+>> such a function if it were used in some of the other places that compare
+>> to index.
+>> 
+>> The other option would be for po to override the template setting.
+>> --[[Joey]] 
+
 Pagespecs
 ---------
 
@@ -327,18 +346,6 @@ Also, this may only happen if the page being linked to is coming from an
 underlay, and the underlays lack translation to a given language.
 --[[Joey]] 
 
-recentchanges links to po files
--------------------------------
-
-When a po file is changed, the recentchanges page shows a link such as
-"sandbox.es". But, clicking on it goes to the English (or negotiated
-language) version of the page. It would be better in this one case if
-the link went direct to the translated version of the page. --[[Joey]] 
-
-> The (untested) commit 496e8523c670 in my po branch might fix this...
-> or at least, I believe, put someone on the right track.
-> --[[intrigeri]]
-
 Double commits of po files
 --------------------------