}
-sub verify_src_file ($$) {
- my $file=shift;
- my $dir=shift;
-
- return if -l $file || -d _;
- $file=~s/^\Q$dir\E\/?//;
- return if ! length $file;
- my $page = pagename($file);
- if (! exists $pagesources{$page} &&
- file_pruned($file)) {
- return;
- }
-
- my ($file_untainted) = $file =~ /$config{wiki_file_regexp}/; # untaint
- if (! defined $file_untainted) {
- warn(sprintf(gettext("skipping bad filename %s"), $file)."\n");
- }
- return ($file_untainted, $page);
-}
-
sub find_src_files () {
my @files;
my %pages;
eval q{use File::Find};
error($@) if $@;
- find({
- no_chdir => 1,
- wanted => sub {
- my ($file, $page) = verify_src_file(decode_utf8($_), $config{srcdir});
- if (defined $file) {
- push @files, $file;
- if ($pages{$page}) {
- debug(sprintf(gettext("%s has multiple possible source pages"), $page));
+
+ my ($page, $dir, $underlay);
+ my $helper=sub {
+ my $file=decode_utf8($_);
+
+ return if -l $file || -d _;
+ $file=~s/^\Q$dir\E\/?//;
+ return if ! length $file;
+ $page = pagename($file);
+ if (! exists $pagesources{$page} &&
+ file_pruned($file)) {
+ $File::Find::prune=1;
+ return;
+ }
+
+ my ($f) = $file =~ /$config{wiki_file_regexp}/; # untaint
+ if (! defined $f) {
+ warn(sprintf(gettext("skipping bad filename %s"), $file)."\n");
+ }
+
+ if ($underlay) {
+ # avoid underlaydir override attacks; see security.mdwn
+ if (! -l "$config{srcdir}/$f" && ! -e _) {
+ if (! $pages{$page}) {
+ push @files, $f;
+ $pages{$page}=1;
}
- $pages{$page}=1;
}
- else {
- $File::Find::prune=1;
+ }
+ else {
+ push @files, $f;
+ if ($pages{$page}) {
+ debug(sprintf(gettext("%s has multiple possible source pages"), $page));
}
- },
- }, $config{srcdir});
- foreach my $dir (@{$config{underlaydirs}}, $config{underlaydir}) {
+ $pages{$page}=1;
+ }
+ };
+
+ find({
+ no_chdir => 1,
+ wanted => $helper,
+ }, $dir=$config{srcdir});
+ $underlay=1;
+ foreach (@{$config{underlaydirs}}, $config{underlaydir}) {
find({
no_chdir => 1,
- wanted => sub {
- my ($file, $page) = verify_src_file(decode_utf8($_), $dir);
- if (defined $file) {
- # avoid underlaydir override
- # attacks; see security.mdwn
- if (! -l "$config{srcdir}/$file" &&
- ! -e _) {
- if (! $pages{$page}) {
- push @files, $file;
- $pages{$page}=1;
- }
- }
- }
- else {
- $File::Find::prune=1;
- }
- },
- }, $dir);
+ wanted => $helper,
+ }, $dir=$_);
};
return \@files, \%pages;
}
push @internal_new, $file;
}
elsif ($config{rcs}) {
- if (! $times_noted) {
- debug(sprintf(gettext("querying %s for file creation and modification times.."), $config{rcs}));
- $times_noted=1;
- }
-
push @new, $file;
if ($config{gettime} && -e "$config{srcdir}/$file") {
+ if (! $times_noted) {
+ debug(sprintf(gettext("querying %s for file creation and modification times.."), $config{rcs}));
+ $times_noted=1;
+ }
+
eval {
my $ctime=rcs_getctime("$config{srcdir}/$file");
if ($ctime > 0) {
foreach my $file (@_) {
my $page=pagename($file);
if (! isinternal($page)) {
- debug(sprintf(gettext("removing old page %s"), $page));
+ debug(sprintf(gettext("removing obsolete %s"), $page));
}
foreach my $old (@{$oldrenderedfiles{$page}}) {
if ($type == $IkiWiki::DEPEND_LINKS) {
next unless $linkchangers->{lc($page)};
}
- return $page;
+ $reason=$page;
+ return 1;
}
}
return undef;
};
if ($depends{$p}{$dep} & $IkiWiki::DEPEND_CONTENT) {
- last if $reason =
- $in->(\@changed, $IkiWiki::DEPEND_CONTENT);
- last if $internal_dep && ($reason =
+ last if $in->(\@changed, $IkiWiki::DEPEND_CONTENT);
+ last if $internal_dep && (
$in->($internal_new, $IkiWiki::DEPEND_CONTENT) ||
$in->($internal_del, $IkiWiki::DEPEND_CONTENT) ||
- $in->($internal_changed, $IkiWiki::DEPEND_CONTENT));
+ $in->($internal_changed, $IkiWiki::DEPEND_CONTENT)
+ );
}
if ($depends{$p}{$dep} & $IkiWiki::DEPEND_PRESENCE) {
- last if $reason =
- $in->(\@exists_changed, $IkiWiki::DEPEND_PRESENCE);
- last if $internal_dep && ($reason =
+ last if $in->(\@exists_changed, $IkiWiki::DEPEND_PRESENCE);
+ last if $internal_dep && (
$in->($internal_new, $IkiWiki::DEPEND_PRESENCE) ||
- $in->($internal_del, $IkiWiki::DEPEND_PRESENCE));
+ $in->($internal_del, $IkiWiki::DEPEND_PRESENCE)
+ );
}
if ($depends{$p}{$dep} & $IkiWiki::DEPEND_LINKS) {
- last if $reason =
- $in->(\@changed, $IkiWiki::DEPEND_LINKS);
- last if $internal_dep && ($reason =
+ last if $in->(\@changed, $IkiWiki::DEPEND_LINKS);
+ last if $internal_dep && (
$in->($internal_new, $IkiWiki::DEPEND_LINKS) ||
$in->($internal_del, $IkiWiki::DEPEND_LINKS) ||
- $in->($internal_changed, $IkiWiki::DEPEND_LINKS));
+ $in->($internal_changed, $IkiWiki::DEPEND_LINKS)
+ );
}
}
}
my $pages=shift;
my $del=shift;
- if (srcfile($autofile, 1)) {
- return 0;
+ if (srcfile($autofile, 1) || file_pruned($autofile)) {
+ return;
}
-
- my ($file, $page) = verify_src_file("$config{srcdir}/$autofile", $config{srcdir});
+ my $file="$config{srcdir}/$autofile" =~ /$config{wiki_file_regexp}/; # untaint
+ if (! defined $file || -l $file || -d _ || -e _) {
+ return;
+ }
+
if ((!defined $file) ||
(exists $wikistate{$autofiles{$autofile}{plugin}}{autofile_deleted})) {
- return 0;
+ return;
}
+ my $page = pagename($file);
if ($pages->{$page}) {
- return 0;
+ return;
}
if (grep { $_ eq $file } @$del) {
- $wikistate{$autofiles{$autofile}{generator}}{autofile_deleted}=1;
- return 0;
+ $wikistate{$autofiles{$autofile}{plugin}}{autofile_deleted}=1;
+ return;
}
$autofiles{$autofile}{generator}->();
sipb-www / ikiwiki.git / blobdiff