bugfix

[ikiwiki.git] / IkiWiki.pm

diff --git a/IkiWiki.pm b/IkiWiki.pm
index 0aaf605694d9fc2a53cb5c527a3b2e38e11da506..c2cadd35f02c9f5a005ae915bb62fca4b1fa9693 100644 (file)
--- a/IkiWiki.pm
+++ b/IkiWiki.pm
@@ -1653,32 +1653,44 @@ sub saveindex () {
 
 sub template_file ($) {
        my $name=shift;
-
-       my $template=srcfile("templates/$name", 1);
-       return $template if defined $template;
        
-       foreach my $dir ($config{templatedir},
-                        "$installdir/share/ikiwiki/templates") {
-               return "$dir/$name" if -e "$dir/$name";
+       my $tpage=($name =~ s/^\///) ? $name : "templates/$name";
+       if ($name !~ /\.tmpl$/ && exists $pagesources{$tpage}) {
+               $tpage=$pagesources{$tpage};
+               $name.=".tmpl";
+       }
+
+       my $template=srcfile($tpage, 1);
+       if (! defined $template) {
+               $name=~s:/::; # avoid path traversal
+               foreach my $dir ($config{templatedir},
+                                "$installdir/share/ikiwiki/templates") {
+                       if (-e "$dir/$name") {
+                               $template="$dir/$name";
+                               last;
+                       }
+               }
        }
-       return;
-}
 
-sub template ($;@) {
-       template_depends(shift, undef, @_);
+       if (defined $template) {        
+               return $template, $tpage if wantarray;
+               return $template;
+       }
+       return;
 }
 
 sub template_depends ($$;@) {
        my $name=shift;
        my $page=shift;
-
-       if (defined $page) {
-               add_depends($page, "templates/$name");
+       
+       my ($filename, $tpage)=template_file($name);
+       if (defined $page && defined $tpage) {
+               add_depends($page, $tpage);
        }
-       my $filename=template_file($name);
 
-       require HTML::Template;
-       return HTML::Template->new(
+       return unless defined $filename;
+
+       my @opts=(
                filter => sub {
                        my $text_ref = shift;
                        ${$text_ref} = decode_utf8(${$text_ref});
@@ -1689,13 +1701,22 @@ sub template_depends ($$;@) {
                @_,
                no_includes => 1,
        );
+       return @opts if wantarray;
+
+       require HTML::Template;
+       return HTML::Template->new(@opts);
+}
+
+sub template ($;@) {
+       template_depends(shift, undef, @_);
 }
 
 sub misctemplate ($$;@) {
        my $title=shift;
        my $pagebody=shift;
        
-       my $template=template("misc.tmpl",
+       my $template=template("misc.tmpl");
+       $template->param(
                title => $title,
                indexlink => indexlink(),
                wikiname => $config{wikiname},