move userlink to IkiWiki.pm

[ikiwiki.git] / IkiWiki / CGI.pm

diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm
index a6695b3a5e6747942733e0cfcdbc7c40a3077e05..5de90e1a84782fda2f8c8d093ee00a6d3b9151d7 100644 (file)
--- a/IkiWiki/CGI.pm
+++ b/IkiWiki/CGI.pm
@@ -57,7 +57,6 @@ sub check_canedit ($$$;$) { #{{{
        my $nonfatal=shift;
        
        my $canedit;
-       my $callback;
        run_hooks(canedit => sub {
                return if defined $canedit;
                my $ret=shift->($page, $q, $session);
@@ -66,12 +65,12 @@ sub check_canedit ($$$;$) { #{{{
                                $canedit=1;
                        }
                        elsif (ref $ret eq 'CODE') {
+                               $ret->() unless $nonfatal;
                                $canedit=0;
-                               $callback->() unless $nonfatal;
                        }
                        elsif (defined $ret) {
-                               $canedit=0;
                                error($ret) unless $nonfatal;
+                               $canedit=0;
                        }
                }
        });
@@ -101,7 +100,7 @@ sub cgi_recentchanges ($) { #{{{
 
        my $changelog=[rcs_recentchanges(100)];
        foreach my $change (@$changelog) {
-               $change->{when} = concise(ago($change->{when}));
+               $change->{when} = concise(ago(time - $change->{when}));
 
                $change->{user} = userlink($change->{user});
 
@@ -276,7 +275,7 @@ sub cgi_prefs ($$) { #{{{
        }
        elsif ($form->submitted eq 'Save Preferences' && $form->validate) {
                foreach my $field (qw(email subscriptions)) {
-                       if (defined $form->field($field) && length $form->field($field)) {
+                       if (defined $form->field($field)) {
                                userinfo_set($user_name, $field, $form->field($field)) ||
                                        error("failed to set $field");
                        }
@@ -719,7 +718,7 @@ sub cgi (;$$) { #{{{
        elsif ($do eq 'create' || $do eq 'edit') {
                cgi_editpage($q, $session);
        }
-       elsif (defined $session->param("postsignin")) {
+       elsif (defined $session->param("postsignin") || $do eq 'postsignin') {
                cgi_postsignin($q, $session);
        }
        else {
@@ -727,32 +726,4 @@ sub cgi (;$$) { #{{{
        }
 } #}}}
 
-sub userlink ($) { #{{{
-       my $user=shift;
-
-       eval q{use CGI 'escapeHTML'};
-       error($@) if $@;
-       if ($user =~ m!^https?://! &&
-           eval q{use Net::OpenID::VerifiedIdentity; 1} && !$@) {
-               # Munge user-urls, as used by eg, OpenID.
-               my $oid=Net::OpenID::VerifiedIdentity->new(identity => $user);
-               my $display=$oid->display;
-               # Convert "user.somehost.com" to "user [somehost.com]".
-               if ($display !~ /\[/) {
-                       $display=~s/^(.*?)\.([^.]+\.[a-z]+)$/$1 [$2]/;
-               }
-               # Convert "http://somehost.com/user" to "user [somehost.com]".
-               if ($display !~ /\[/) {
-                       $display=~s/^https?:\/\/(.+)\/([^\/]+)$/$2 [$1]/;
-               }
-               $display=~s!^https?://!!; # make sure this is removed
-               return "<a href=\"$user\">".escapeHTML($display)."</a>";
-       }
-       else {
-               return htmllink("", "", escapeHTML(
-                       length $config{userdir} ? $config{userdir}."/".$user : $user
-               ), noimageinline => 1);
-       }
-} #}}}
-
 1