htmltidy robustness fixes

[ikiwiki.git] / IkiWiki / Plugin / htmltidy.pm

diff --git a/IkiWiki/Plugin/htmltidy.pm b/IkiWiki/Plugin/htmltidy.pm
index 5a6a494ed418331c4e07a57864a7df15f45e0d71..9ba5e9592b0c84482e01175c5881f901315a4397 100644 (file)
--- a/IkiWiki/Plugin/htmltidy.pm
+++ b/IkiWiki/Plugin/htmltidy.pm
@@ -9,24 +9,46 @@ package IkiWiki::Plugin::htmltidy;
 
 use warnings;
 use strict;
-use IkiWiki;
+use IkiWiki 2.00;
 use IPC::Open2;
 
 sub import { #{{{
-       IkiWiki::hook(type => "sanitize", id => "tidy", call => \&sanitize);
+       hook(type => "getsetup", id => "tidy", call => \&getsetup);
+       hook(type => "sanitize", id => "tidy", call => \&sanitize);
 } # }}}
 
-sub sanitize ($) { #{{{
-       open2(*IN, *OUT, 'tidy -quiet -asxhtml -indent -utf8 --show-body-only yes --show-warnings no --tidy-mark no') or return shift;
+sub getsetup () { #{{{
+       return
+               plugin => {
+                       safe => 1,
+                       rebuild => undef,
+               },
+} #}}}
+
+sub sanitize (@) { #{{{
+       my %params=@_;
+
+       my $pid;
+       my $sigpipe=0;
+       $SIG{PIPE}=sub { $sigpipe=1 };
+       $pid=open2(*IN, *OUT, 'tidy -quiet -asxhtml -utf8 --show-body-only yes --show-warnings no --tidy-mark no --markup yes 2>/dev/null');
+
        # open2 doesn't respect "use open ':utf8'"
-       binmode (IN, ':utf8'); 
-       binmode (OUT, ':utf8'); 
+       binmode (IN, ':utf8');
+       binmode (OUT, ':utf8');
        
-       print OUT shift;
+       print OUT $params{content};
        close OUT;
 
        local $/ = undef;
-       return <IN>;
+       my $ret=<IN>;
+       close IN;
+       waitpid $pid, 0;
+
+       $SIG{PIPE}="DEFAULT";
+       return "" if $sigpipe || ! defined $ret;
+
+       return $ret;
 } # }}}
 
 1