X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/361ce5d3a989076040422daa5fe22e8c4a5136a6..e2924778de755bee6d653fd4349214ba13228bd8:/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn diff --git a/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn b/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn index b9b6a23e9..ac6d6db1e 100644 --- a/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn +++ b/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn @@ -2,4 +2,24 @@ Since upgrading from Ikiwiki 2.20 to 2.32.3 (from Debian Lenny), I don't get hyp EDIT: I just found that in this wiki under the entry "mailto: links not properly generated in rss/atom feeds" also doesn't have a hyperlink - at least it's not a problem with my config only ;-) -[[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If enabled, then `$safe_url_regexp` determines the URL unsafe because of the colon and hence removes the `src` attribute. +[[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If +enabled, then `$safe_url_regexp` determines the URL unsafe because of the +colon and hence removes the `src` attribute. + +Digging into this, I find that [[rfc 3986]] pretty much discourages colons in +filenames: + +> A path segment that contains a colon character (e.g., "this:that") cannot be +> used as the first segment of a relative-path reference, as it would be +> mistaken for a scheme name. Such a segment must be preceded by +> a dot-segment (e.g., "./this:that") to make a relative- path reference. + +The solution seems not to use colons. + +In any case, `htmlscrubber` should get a new regexp, courtesy of dato: +`[^:]+($|\/)`. I have tested and verified this. + +[Commit/patch +be0b4f60](http://git.madduck.net/v/code/ikiwiki.git?a=commit;h=be0b4f603f918444b906e42825908ddac78b7073) fixes this. + +[[done]]