X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/3d7147992ab24d953c87b91f75851ca45895073c..b2a8f0f5b43cf5c5126c800be999cbda5e49bc54:/doc/todo/feed_enhancements_for_inline_pages.mdwn

diff --git a/doc/todo/feed_enhancements_for_inline_pages.mdwn b/doc/todo/feed_enhancements_for_inline_pages.mdwn
index fde5ac01f..46b6a2512 100644
--- a/doc/todo/feed_enhancements_for_inline_pages.mdwn
+++ b/doc/todo/feed_enhancements_for_inline_pages.mdwn
@@ -26,6 +26,8 @@ name’. As explained in the commit message for the patch itself, this is
 a ‘forgotten part’ from a previous page vs destpage fix which has
 already been included upstream.
 
+> Applied. --[[Joey]] 
+
 The second patch, ‘inline: improve feed title and description
 management’, aligns feed title and description management by introducing
 a `title` option to complement `description`, and by basing the
@@ -34,11 +36,20 @@ description is provided by either the directive parameter or the page
 metadata, we use a user-configurable default based on both the page
 title and wiki name rather than hard-coding the wiki name as description.
 
+> Reviewing, this seems ok, but I don't like that 
+> `feed_desc_fmt` is "safe => 0". And I question if that needs
+> to be configurable at all. I say, drop that configurable, and
+> only use the page meta description (or wikiname for index).
+> 
+> Oh, and could you indent your `elsif` the same as I? --[[Joey]] 
+
 The third patch, ‘inline: allow assigning an id to postform/feedlink’,
 does just that. I don't currently use it, but it can be particularly
 useful in the postform case for example for scriptable management of
 multiple postforms in the same page.
 
+> Applied. --[[Joey]] 
+
 In one of my wiki setups I had a terminating '/' in `$config{url}`. You
 mention that it should not be present, but I have not seen this
 requirement described anywhere. Rather than restricting the user input,