X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/52bbdbb1a5ce994c9afac253c1d9bfd94acf4d1d..3069c7b36a96cc27a8c5bed8e908bb3774ba8cac:/IkiWiki/Setup/Standard.pm

diff --git a/IkiWiki/Setup/Standard.pm b/IkiWiki/Setup/Standard.pm
index d8547ba5f..92f887f0c 100644
--- a/IkiWiki/Setup/Standard.pm
+++ b/IkiWiki/Setup/Standard.pm
@@ -10,7 +10,7 @@ use strict;
 use IkiWiki;
 
 sub import { #{{{
-	$IkiWiki::Setup::raw_setup=$_[1];
+	IkiWiki::Setup::merge($_[1]);
 } #}}}
 
 sub dumpline ($$$$) { #{{{
@@ -28,19 +28,28 @@ sub dumpline ($$$$) { #{{{
 	local $Data::Dumper::Quotekeys=0;
 	
 	my $dumpedvalue;
-	if ($type eq 'boolean' || $type eq 'integer') {
+	if (($type eq 'boolean' || $type eq 'integer') && $value=~/^[0-9]+$/) {
 		# avoid quotes
 		$dumpedvalue=$value;
 	}
-	elsif ($type eq 'string' && ref $value eq 'ARRAY' && @$value &&
-	    ! grep { /[^-A-Za-z0-9_]/ } @$value) {
+	elsif (ref $value eq 'ARRAY' && @$value && ! grep { /[^\S]/ } @$value) {
 		# dump simple array as qw{}
-		$dumpedvalue="[qw{ ".join(" ", @$value)." }]";
+		$dumpedvalue="[qw{".join(" ", @$value)."}]";
 	}
 	else {
 		$dumpedvalue=Dumper($value);
 		chomp $dumpedvalue;
+		if (length $prefix) {
+			# add to second and subsequent lines
+			my @lines=split(/\n/, $dumpedvalue);
+			$dumpedvalue="";
+			for (my $x=0; $x <= $#lines; $x++) {
+				$lines[$x] =~ s/^\t//;
+				$dumpedvalue.="\t".($x ? $prefix : "").$lines[$x]."\n";
+			}
+		}
 		$dumpedvalue=~s/^\t//;
+		chomp $dumpedvalue;
 	}
 	
 	return "\t$prefix$key => $dumpedvalue,";
@@ -53,7 +62,7 @@ sub dumpvalues ($@) { #{{{
 		my $key=shift;
 		my %info=%{shift()};
 
-		next if $info{type} eq "internal";
+		next if $key eq "plugin" || $info{type} eq "internal";
 		
 		push @ret, "\t# ".$info{description} if exists $info{description};
 		
@@ -61,12 +70,12 @@ sub dumpvalues ($@) { #{{{
 			push @ret, dumpline($key, $setup->{$key}, $info{type}, "");
 			delete $setup->{$key};
 		}
-		elsif (exists $info{default} && defined $info{default}) {
-			push @ret, dumpline($key, $info{default}, $info{type}, "#");
-		}
 		elsif (exists $info{example}) {
 			push @ret, dumpline($key, $info{example}, $info{type}, "#");
 		}
+		else {
+			push @ret, dumpline($key, "", $info{type}, "#");
+		}
 	}
 	return @ret;
 } #}}}
@@ -76,30 +85,19 @@ sub gendump ($) { #{{{
 	my %setup=(%config);
 	my @ret;
 	
-	push @ret, "\t# basic setup";
-	push @ret, dumpvalues(\%setup, IkiWiki::getsetup());
+	# disable logging to syslog while dumping
+	$config{syslog}=undef;
 
-	# Load all plugins, so that all setup options are available.
-	my @plugins=sort(IkiWiki::listplugins());
-	foreach my $plugin (@plugins) {
-		eval { IkiWiki::loadplugin($plugin) };
-		if (exists $IkiWiki::hooks{checkconfig}{$plugin}{call}) {
-			my @s=eval { $IkiWiki::hooks{checkconfig}{$plugin}{call}->() };
+	push @ret, dumpvalues(\%setup, IkiWiki::getsetup());
+	foreach my $pair (IkiWiki::Setup::getsetup()) {
+		my $plugin=$pair->[0];
+		my $setup=$pair->[1];
+		my @values=dumpvalues(\%setup, @{$setup});
+		if (@values) {
+			push @ret, "", "\t# $plugin plugin", @values;
 		}
 	}
-	unshift @plugins, $config{rcs} if $config{rcs};
 
-	foreach my $id (@plugins) {
-		my $title="\t# $id".($id ne $config{rcs} ? " plugin" : "");
-		if (exists $IkiWiki::hooks{getsetup}{$id}{call}) {
-			# use an array rather than a hash, to preserve order
-			my @s=eval { $IkiWiki::hooks{getsetup}{$id}{call}->() };
-			next unless @s;
-			push @ret, "", $title;
-			push @ret, dumpvalues(\%setup, @s);
-		}
-	}
-	
 	unshift @ret,
 		"#!/usr/bin/perl",
 		"# $description",