X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/582e52d3ca79d0d5d0335486718fe2167d6304cd..007eded20cb9ba9d528281a41a95b54db2157df5:/doc/todo/support_linking_to_cgit.mdwn diff --git a/doc/todo/support_linking_to_cgit.mdwn b/doc/todo/support_linking_to_cgit.mdwn index 92c7cb8a6..ab6172ad1 100644 --- a/doc/todo/support_linking_to_cgit.mdwn +++ b/doc/todo/support_linking_to_cgit.mdwn @@ -17,4 +17,29 @@ the substitution of `\[[file]]` in `diffurl` and `historyurl`? > In `91b477c` I made a similar change to how the cvs backend encodes > `diffurl`. Perhaps it applies to all VCS backends? --[[schmonz]] +>> Thanks a lot! I've not looked at it yet, but will try to do so +>> soonish, as this bug is a real problem for Tails when welcoming potential +>> new contributors. --[[intrigeri]] + +>>> My `fix_diffurl_vs._cgit` branch now implements schmonz' change +>>> for the Git plugin. Please review and merge if you like +>>> it. --[[intrigeri]] + +>>>> Ping? --[[intrigeri]] + +>>>> Normally, my tendency towards pedantic preservation of existing APIs +>>>> would make me implement a new token \[[file_less_escaped]] or +>>>> something, analogous to `%s` vs. `%S` in [[shortcuts]]; but +>>>> gitweb and cgit are both OK with `/` not being escaped, whereas +>>>> only gitweb allows it to be escaped as `%2F`, so I think your +>>>> solution is fine. Also, it would need a much better name than +>>>> \[[file_less_escaped]], and I can't think of one. +>>>> +>>>> I don't have commit access to ikiwiki.info, but if I did, +>>>> [[I'd merge this|/users/smcv/yesplease]]. --[[smcv]] + +>>>>> [[merged|done]] --[[Joey]] + [[wishlist]] + +[[!tag patch]]