X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/85de2f7bc4d00a4a4711cd91224553beae411532..255172215e8d886ae875e79694bda1a656053410:/IkiWiki/Plugin/teximg.pm

diff --git a/IkiWiki/Plugin/teximg.pm b/IkiWiki/Plugin/teximg.pm
index 5dff5feef..6a6bdd4fa 100644
--- a/IkiWiki/Plugin/teximg.pm
+++ b/IkiWiki/Plugin/teximg.pm
@@ -27,14 +27,14 @@ sub preprocess (@) { #{{{
 	
 	my $code = $params{code};
 	if (! defined $code && ! length $code) {
-		return "[[teximg ".gettext("missing tex code"). "]]";
+		error gettext("missing tex code");
 	}
 
 	if (check($code)) {
 		return create($code, check_height($height), \%params);
 	}
 	else {
-		return "[[teximg ".gettext("code includes disallowed latex commands"). "]]";
+		error gettext("code includes disallowed latex commands")
 	}
 } #}}}
 
@@ -72,19 +72,11 @@ sub create ($$$) { #{{{
 
 	my $imglink= $params->{page} . "/$digest.png";
 	my $imglog =  $params->{page} .  "/$digest.log";
-	will_render($params->{destpage}, $imglink);
-	will_render($params->{destpage}, $imglog);
-
-	my $imgurl;
-	my $logurl;
-	if (! $params->{preview}) {
-		$imgurl = urlto($imglink, $params->{destpage});
-		$logurl = urlto($imglog, $params->{destpage});
-	}
-	else {
-		$imgurl=$params->{page}."/$digest.png";
-		$logurl=$params->{page}."/$digest.log";
-	}
+	will_render($params->{page}, $imglink);
+	will_render($params->{page}, $imglog);
+
+	my $imgurl=urlto($imglink, $params->{destpage});
+	my $logurl=urlto($imglog, $params->{destpage});
 	
 	if (-e "$config{destdir}/$imglink" ||
 	    gen_image($code, $height, $digest, $params->{page})) {
@@ -93,7 +85,7 @@ sub create ($$$) { #{{{
 			.qq{" class="teximg" />};
 	}
 	else {
-		return qq{[[teximg <a href="$logurl">}.gettext("failed to generate image from code")."</a>]]";
+		error qq{<a href="$logurl">}.gettext("failed to generate image from code")."</a>";
 	}
 } #}}}
 
@@ -127,12 +119,13 @@ sub gen_image ($$$$) { #{{{
 	}
 	else {
 		# store failure log
-		my $log;
+		my $log="";
 		{
-			open(my $f, '<', "$tmp/$digest.log");
-			local $/=undef;
-			$log = <$f>;
-			close($f);
+			if (open(my $f, '<', "$tmp/$digest.log")) {
+				local $/=undef;
+				$log = <$f>;
+				close($f);
+			}
 		}
 		writefile("$digest.log", "$config{destdir}/$imagedir", $log);