X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/8ebf6acd80e9c6dfbf101ad046c907feebfef2b1..0c9a504948fec4f55ae1ebb4f698a20246cb6a9e:/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn diff --git a/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn b/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn index 8f320ec3b..ac6d6db1e 100644 --- a/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn +++ b/doc/bugs/No_link_for_blog_items_when_filename_contains_a_colon.mdwn @@ -2,7 +2,9 @@ Since upgrading from Ikiwiki 2.20 to 2.32.3 (from Debian Lenny), I don't get hyp EDIT: I just found that in this wiki under the entry "mailto: links not properly generated in rss/atom feeds" also doesn't have a hyperlink - at least it's not a problem with my config only ;-) -[[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If enabled, then `$safe_url_regexp` determines the URL unsafe because of the colon and hence removes the `src` attribute. +[[madduck]]: I traced this down to `htmlscrubber`. If disabled, it works. If +enabled, then `$safe_url_regexp` determines the URL unsafe because of the +colon and hence removes the `src` attribute. Digging into this, I find that [[rfc 3986]] pretty much discourages colons in filenames: @@ -12,9 +14,12 @@ filenames: > mistaken for a scheme name. Such a segment must be preceded by > a dot-segment (e.g., "./this:that") to make a relative- path reference. -on the other hand, with `usedirs`, any link to another page will be prepended -by `../` anyway, so that makes them okay again. +The solution seems not to use colons. -The solution still seems not to use colons. +In any case, `htmlscrubber` should get a new regexp, courtesy of dato: +`[^:]+($|\/)`. I have tested and verified this. -In any case, `htmlscrubber` should get a new regexp, courtesy of dato: `[^:]+($|\/)`. I have tested and verified this. +[Commit/patch +be0b4f60](http://git.madduck.net/v/code/ikiwiki.git?a=commit;h=be0b4f603f918444b906e42825908ddac78b7073) fixes this. + +[[done]]