X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/a44bfb158dac9e04647a75bc819a73bc18f5acce..6351ae2ac4ffe01aba0733469751be7e058e6e61:/IkiWiki/Plugin/brokenlinks.pm

diff --git a/IkiWiki/Plugin/brokenlinks.pm b/IkiWiki/Plugin/brokenlinks.pm
index 8b91391fe..d9d50f75f 100644
--- a/IkiWiki/Plugin/brokenlinks.pm
+++ b/IkiWiki/Plugin/brokenlinks.pm
@@ -7,8 +7,7 @@ use strict;
 use IkiWiki;
 
 sub import { #{{{
-	IkiWiki::hook(type => "preprocess", id => "brokenlinks",
-		call => \&preprocess);
+	hook(type => "preprocess", id => "brokenlinks", call => \&preprocess);
 } # }}}
 
 sub preprocess (@) { #{{{
@@ -17,25 +16,27 @@ sub preprocess (@) { #{{{
 	
 	# Needs to update whenever a page is added or removed, so
 	# register a dependency.
-	IkiWiki::add_depends($params{page}, $params{pages});
+	add_depends($params{page}, $params{pages});
 	
 	my @broken;
-	foreach my $page (%IkiWiki::links) {
-		if (IkiWiki::globlist_match($page, $params{pages})) {
-			foreach my $link (@{$IkiWiki::links{$page}}) {
-				next if $link =~ /.*\/discussion/i;
-				my $bestlink=IkiWiki::bestlink($page, $link);
+	foreach my $page (keys %links) {
+		if (pagespec_match($page, $params{pages}, $params{page})) {
+			my $discussion=gettext("discussion");
+			foreach my $link (@{$links{$page}}) {
+				next if $link =~ /.*\/\Q$discussion\E/i && $config{discussion};
+				my $bestlink=bestlink($page, $link);
 				next if length $bestlink;
 				push @broken,
-					IkiWiki::htmllink($page, $link, 1).
-					" in ".
-					IkiWiki::htmllink($params{page}, $page, 1);
+					htmllink($page, $params{destpage}, $link, noimageinline => 1).
+					" from ".
+					htmllink($params{page}, $params{destpage}, $page, noimageinline => 1);
 			}
 		}
 	}
 	
-	return "There are no broken links!" unless @broken;
-	return "<ul>\n".join("\n", map { "<li>$_</li>" } sort @broken)."</ul>\n";
+	return gettext("There are no broken links!") unless @broken;
+	my %seen;
+	return "<ul>\n".join("\n", map { "<li>$_</li>" } grep { ! $seen{$_}++ } sort @broken)."</ul>\n";
 } # }}}
 
 1