X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/ac4a11ba50b4093bebe32d99c48c0de53ca414d8..8a8277faf8a084694745cfd20906733df46b4ff9:/doc/bugs/Can__39__t_create_root_page.mdwn diff --git a/doc/bugs/Can__39__t_create_root_page.mdwn b/doc/bugs/Can__39__t_create_root_page.mdwn index b56f3bddc..91c2eae60 100644 --- a/doc/bugs/Can__39__t_create_root_page.mdwn +++ b/doc/bugs/Can__39__t_create_root_page.mdwn @@ -16,6 +16,9 @@ This type of page name (with leading slash) also gets created by the aggregate p > /subdir/subpage, when a user clicks the "?" link to create > the missing page ; that's why I'm using absolute paths. > +>> Totally agree, this had only not been addressed due to lack of time on +>> my part. (I have about 50 ikiwiki things on my todo list.) --[[Joey]] +> > Anyway, having the CGI consider invalid an otherwise valid wikilink > seems a bit weird to me, so I had a look to the code, and here is a > patch that should fix this issue ; I proceeded the only way I could @@ -30,7 +33,7 @@ This type of page name (with leading slash) also gets created by the aggregate p index 99cead6..23d9616 100644 --- a/IkiWiki/CGI.pm +++ b/IkiWiki/CGI.pm - @@ -305,9 +305,11 @@ sub cgi_editpage ($$) { #{{{ + @@ -305,9 +305,11 @@ sub cgi_editpage ($$) { my $page=$form->field('page'); $page=possibly_foolish_untaint($page); if (! defined $page || ! length $page || @@ -43,7 +46,7 @@ This type of page name (with leading slash) also gets created by the aggregate p my $baseurl=$config{url}."/".htmlpage($page); - @@ -425,6 +427,7 @@ sub cgi_editpage ($$) { #{{{ + @@ -425,6 +427,7 @@ sub cgi_editpage ($$) { $from ne $form->field('from') || file_pruned($from, $config{srcdir}) || $from=~/^\// || @@ -52,4 +55,15 @@ This type of page name (with leading slash) also gets created by the aggregate p @page_locs=$best_loc=$page; } -[[tag patch]] + +> [[Applied|done]]. BTW, I also accept full git changesets, if you like +> having your name in commit logs. :-) + +>> Thanks. I'm considering setting up a public Git repository with topic branches, so that : + +>> - I can simply ask you to pull from there, next time +>> - I have a tool to go on learning the beast (i.e. Git) + +>> -- intrigeri + +[[!tag patch]]