X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/bf0589f116effb4edc26afaa7a8b01f56730b8ba..9df6ef9c861bec06a2cae7ec8b8c5d6725392035:/doc/bugs/Insecure_dependency_in_mkdir.mdwn diff --git a/doc/bugs/Insecure_dependency_in_mkdir.mdwn b/doc/bugs/Insecure_dependency_in_mkdir.mdwn index ad7a64193..28304b3d3 100644 --- a/doc/bugs/Insecure_dependency_in_mkdir.mdwn +++ b/doc/bugs/Insecure_dependency_in_mkdir.mdwn @@ -54,3 +54,76 @@ I can't see any related entries. Any ideas? >> drwxr-xr-x 5 ptecza ptecza 4096 2007-12-17 16:54 blog >> >> --[[Paweł|ptecza]] + +>> I need a set of files that you know I can use to reproduce the bug. +>> --[[Joey]] + +>>> OK, I've just sent you the URL where you can find all files you need :) +>>> +>>> Probably I know how to reproduce the bug. You have to erase all files from +>>> `/var/www/blog` before mass rebuilding. This is my `mass-rebuild.sh` script: +>>> +>>> #!/bin/bash +>>> +>>> rm -rf /var/www/blog/* +>>> ikiwiki --setup ikiwiki.setup --getctime --verbose +>>> +>>> I noticed that the bug was "resolved" when I added to my blog new entry +>>> and commited the changes. Before I created all directories and touched +>>> empty `*.html` files in `/var/www/blog` directory. Probably it's not +>>> necessary, because without a new blog revision the bug still existed +>>> and `ikiwiki` still failed. +>>> +>>> --[[Paweł|ptecza]] + +>> I'd forgotten about [this perl bug](http://bugs.debian.org/411786). +>> All I can do is work around it by disabling the taint checking. :-( +>> (Which I've [[done]].) --[[Joey]] + +>>> Ubuntu Gutsy also has Perl 5.8.8-7, so probably it has the bug too. +>>> --[[Paweł|ptecza]] + +>>>> I just got it while building my latest version of git.ikiwiki.info + my stuff. +>>>> Only thing different in my version in IkiWiki.pm is that I moved a </a> over +>>>> a word (for createlink), and disabled the lowercasing of created pages. Running +>>>> Lenny's Perl. --[[simonraven]] + +>>>> Simon, I'm not clear what version of ikiwiki you're using. +>>>> Since version 2.40, taint checking has been disabled by +>>>> default due to the underlying perl bug. Unless you +>>>> build ikiwiki with NOTAINT=0. --[[Joey]] + +>>>> Hi, nope not doing this. Um, sorry, v. 3.13. I've no idea why it suddenly started doing this. +>>>> It wasn't before. I've been messing around IkiWiki.pm to see if I can set +>>>> a umask for `mkdir`. + +line 775 and down: ++ umask ($config{umask} || 0022); + +>>>> I figured it *might* be the `umask`, but I'll see in a few when / if it gets past that in the build. No; I keep getting garbage during the brokenlinks test + +
+t/basewiki_brokenlinks.....Insecure dependency in mkdir while running with -T switch at IkiWiki.pm line 776.
+
+#   Failed test at t/basewiki_brokenlinks.t line 11.
+
+#   Failed test at t/basewiki_brokenlinks.t line 19.
+
+
+broken links found
+<li>shortcut from <a href="./shortcuts/">shortcuts</a></li></ul>
+
+
+
+#   Failed test at t/basewiki_brokenlinks.t line 25.
+Insecure dependency in mkdir while running with -T switch at IkiWiki.pm line 776.
+
+#   Failed test at t/basewiki_brokenlinks.t line 11.
+
+#   Failed test at t/basewiki_brokenlinks.t line 25.
+# Looks like you failed 5 tests of 12.
+dubious
+        Test returned status 5 (wstat 1280, 0x500)
+
+ +>>>> I get this over and over... I haven't touched that AFAICT, at all. --[[simonraven]]