X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/c0cf13dbb064f354eb84430d10747fc0b454f408..122636308f908e877342a9ec2b361eaba2e9b637:/IkiWiki/Plugin/search.pm

diff --git a/IkiWiki/Plugin/search.pm b/IkiWiki/Plugin/search.pm
index 942b94986..61e9214e6 100644
--- a/IkiWiki/Plugin/search.pm
+++ b/IkiWiki/Plugin/search.pm
@@ -31,7 +31,7 @@ sub getopt () { #{{{
 sub checkconfig () { #{{{
 	foreach my $required (qw(url cgiurl)) {
 		if (! length $config{$required}) {
-			error("Must specify $required when using the search plugin\n");
+			error(sprintf(gettext("Must specify %s when using the search plugin"), $required));
 		}
 	}
 } #}}}
@@ -55,17 +55,18 @@ sub pagetemplate (@) { #{{{
 } #}}}
 
 sub delete (@) { #{{{
-	debug("cleaning hyperestraier search index");
+	debug(gettext("cleaning hyperestraier search index"));
 	estcmd("purge -cl");
 	estcfg();
 } #}}}
 
 sub change (@) { #{{{
-	debug("updating hyperestraier search index");
+	debug(gettext("updating hyperestraier search index"));
 	estcmd("gather -cm -bc -cl -sd",
 		map {
-			Encode::encode_utf8($config{destdir}."/".$_)
-				foreach @{$renderedfiles{pagename($_)}};
+			map {
+				Encode::encode_utf8($config{destdir}."/".$_)
+			} @{$renderedfiles{pagename($_)}};
 		} @_
 	);
 	estcfg();
@@ -89,14 +90,20 @@ sub estcfg () { #{{{
 	my $estdir="$config{wikistatedir}/hyperestraier";
 	my $cgi=IkiWiki::basename($config{cgiurl});
 	$cgi=~s/\..*$//;
-	open(TEMPLATE, ">:utf8", "$estdir/$cgi.tmpl") ||
-		error("write $estdir/$cgi.tmpl: $!");
+
+	my $newfile="$estdir/$cgi.tmpl.new";
+	my $cleanup = sub { unlink($newfile) };
+	open(TEMPLATE, ">:utf8", $newfile) || error("open $newfile: $!", $cleanup);
 	print TEMPLATE IkiWiki::misctemplate("search", 
 		"<!--ESTFORM-->\n\n<!--ESTRESULT-->\n\n<!--ESTINFO-->\n\n",
-		baseurl => IkiWiki::dirname($config{cgiurl})."/");
-	close TEMPLATE;
-	open(TEMPLATE, ">$estdir/$cgi.conf") ||
-		error("write $estdir/$cgi.conf: $!");
+		baseurl => IkiWiki::dirname($config{cgiurl})."/") ||
+			error("write $newfile: $!", $cleanup);
+	close TEMPLATE || error("save $newfile: $!", $cleanup);
+	rename($newfile, "$estdir/$cgi.tmpl") ||
+		error("rename $newfile: $!", $cleanup);
+	
+	$newfile="$estdir/$cgi.conf";
+	open(TEMPLATE, ">$newfile") || error("open $newfile: $!", $cleanup);
 	my $template=template("estseek.conf");
 	eval q{use Cwd 'abs_path'};
 	$template->param(
@@ -105,13 +112,15 @@ sub estcfg () { #{{{
 		destdir => abs_path($config{destdir}),
 		url => $config{url},
 	);
-	print TEMPLATE $template->output;
-	close TEMPLATE;
+	print TEMPLATE $template->output || error("write $newfile: $!", $cleanup);
+	close TEMPLATE || error("save $newfile: $!", $cleanup);
+	rename($newfile, "$estdir/$cgi.conf") ||
+		error("rename $newfile: $!", $cleanup);
+
 	$cgi="$estdir/".IkiWiki::basename($config{cgiurl});
 	unlink($cgi);
 	my $estseek = defined $config{estseek} ? $config{estseek} : '/usr/lib/estraier/estseek.cgi';
-	symlink($estseek, $cgi) ||
-		error("symlink $estseek $cgi: $!");
+	symlink($estseek, $cgi) || error("symlink $estseek $cgi: $!");
 } # }}}
 
 sub estcmd ($;@) { #{{{
@@ -127,7 +136,7 @@ sub estcmd ($;@) { #{{{
 		foreach (@_) {
 			print CHILD "$_\n";
 		}
-		close(CHILD) || error("estcmd @params exited nonzero: $?");
+		close(CHILD) || print STDERR "estcmd @params exited nonzero: $?\n";
 	}
 	else {
 		# child