X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/f0f28c38968434f4aa9855e163bb500c36ad5189..a18d99c3faee999cb8f23fc5cb7d07bf6670701f:/doc/bugs/Monotone_rcs_support.mdwn

diff --git a/doc/bugs/Monotone_rcs_support.mdwn b/doc/bugs/Monotone_rcs_support.mdwn
index fad95d155..d1ef00246 100644
--- a/doc/bugs/Monotone_rcs_support.mdwn
+++ b/doc/bugs/Monotone_rcs_support.mdwn
@@ -44,38 +44,13 @@ Note: This patch requires a rather recent Monotone perl module (18 August 2007 o
 >>> and a bug in page adding.
 >>> Here is a small patch for them:
 
-    Index: IkiWiki/Rcs/monotone.pm
-    ===================================================================
-    --- IkiWiki/Rcs/monotone.pm	(revision 4195)
-    +++ IkiWiki/Rcs/monotone.pm	(working copy)
-    @@ -245,6 +245,9 @@
-     		# FIXME: use of $file in these backticks is not wise from a
-     		# security POV. Probably safe, but should be avoided
-     		# anyway.
-    +		# At the moment the backticks are used because the above call using the automate
-    +		# interface was failing.  When that bug in monotone is fixed, we should switch
-    +		# back.
-     		my $diff = `mtn --root=$config{mtnrootdir} au content_diff -r $oldrev -r $rev $file`; # was just $out;
-     
-     		if ($diff) {
-    @@ -314,8 +317,6 @@
-     						"Please use the non-web interface to resolve the conflicts.");
-     				}
-     				
-    -				# suspend this revision because it has
-    -				# conflict markers...
-     				if (system("mtn", "--root=$config{mtnrootdir}",
-     				           "update", "-r", $mergeResult) != 0) {
-     					debug("Unable to update to rev $mergeResult after conflict-enhanced merge on conflicted commit!");
-    @@ -363,7 +364,7 @@
-     	check_config();
-     
-     	if (system("mtn", "--root=$config{mtnrootdir}", "add", "--quiet",
-    -	           "$config{srcdir}/$file") != 0) {
-    +	           $file) != 0) {
-     		error("Monotone add failed");
-     	}
-     } #}}}
+>>>> applied
+
+Here is another patch.  It fixes a FIXME you added.  I was using $file within backticks because
+I was getting an error trying to do it right.  I've figured out the error, and now do it right.  This
+should also speed things up (very slightly)
+
+> applied
 
 >> BTW, will all the monotone output parsing work if LANG != C?
 
@@ -91,4 +66,5 @@ Note: This patch requires a rather recent Monotone perl module (18 August 2007 o
 >>> calling Ikiwiki seems reasonable, but I've not written the
 >>> Lua hook.
 
->> --[[Joey]]
+>>>> So the rcs_notify support is not just untested, but can't work
+>>>> at all w/o further development.