X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/blobdiff_plain/f9ddfe56b9b4bb8c33e96263c0ee02c97b93dc4f..74bc4af99884f149853914a4a5dea5ea9331ed38:/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn

diff --git a/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn b/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn
index 5d1a96fda..a1b38257a 100644
--- a/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn
+++ b/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn
@@ -8,6 +8,21 @@ should be written as
 
 `my @buttons=(gettext("Save Page"), gettext("Preview"), gettext("Cancel"));`
 
+> Yes, these need to be fixed. But note that the localised texts come back
+> into ikiwiki and are used in various places, including plugins.
+> Including, possibly, third-party plugins. So localising the buttons would
+> seem to require converting from the translations back into the C locale
+> when the form is posted. --[[Joey]]
+
+>> Wouldn't it be more easy to change all calls to the corrects ones (including in plugins) ?
+>> For instance in the same file (CGI.pm): `elsif ($form->submitted eq gettext("Save Page")) {`.
+>> That way no conversion to the C locale is needed.
+>> gettext use should just be publicized in documentation (at least in [[plugins/write]]). --[[bbb]]
+
+>>> It would be easy, but it could break third-party plugins that hardcode
+>>> the english strings. It's also probably less efficient to run gettext
+>>> over and over. --[[Joey]]
+
 In standards templates things seems wrongly written too. For instance in page.tmpl line like:
 
 `<li><a href="<TMPL_VAR EDITURL>" rel="nofollow">Edit</a></li>`
@@ -20,6 +35,13 @@ with EDITURL_TEXT variable initialized in Render.pm through a gettext call.
 
 Am I wrong ?
 
-If not I can spend some time preparing patch for such correction if it can help.
+> No, that's not a sane way to localise the templates. The templates can be
+> translated by making a copy and modifying it, or by using a tool to
+> generate .mo files from the templates, and generate translated templates
+> from .po files. (See [[todo/l10n]] for one attempt.) But pushing the
+> localisation of random strings in the templates through the ikiwiki
+> program defeats the purpose of having templates at all. --[[Joey]]
+
+If not I can spend some time preparing patches for such corrections if it can help.
 
--- [[users/bbb]]
+-- [[/users/bbb]]