respond
authorSimon McVittie <smcv@debian.org>
Wed, 5 Jan 2011 12:17:17 +0000 (12:17 +0000)
committerSimon McVittie <smcv@debian.org>
Wed, 5 Jan 2011 12:17:17 +0000 (12:17 +0000)
doc/bugs/preview_base_url_should_be_absolute.mdwn

index b72831b16f75da2308090d5740cd3de79c1f9de8..fb9a05951cf908dc1c879df306449ac940fdd86a 100644 (file)
@@ -3,3 +3,20 @@ absolute, which can break the preview function in some circumstances
 (with e.g. images not showing). The trivial [[patch]] that fixes
 it can be found [[here|http://sprunge.us/EPHT]] as well as on [[my
 git|http://git.oblomov.eu/ikiwiki]].
 (with e.g. images not showing). The trivial [[patch]] that fixes
 it can be found [[here|http://sprunge.us/EPHT]] as well as on [[my
 git|http://git.oblomov.eu/ikiwiki]].
+
+> That patch does mean that if you're accessing the CGI via HTTPS but your
+> $config{url} and $config{cgiurl} are HTTP, you'll get preview images loaded
+> via HTTP, causing the browser to complain. See
+> [[todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both]]
+> for background.
+>
+> Perhaps the CGI could form its `<base>` URL by using
+> `URI->new_abs(urlto(...), $cgi->url)` instead?
+>
+> You'd also need to change `IkiWiki/Wrapper.pm` to pass at least the
+> SERVER_NAME and SERVER_PORT through the environment, probably.
+>
+> Joey's last comment on
+> [[todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both]]
+> suggests that this might already work, but I'm not quite sure how - I'd
+> expect it to need more environment variables? --[[smcv]]