]> sipb.mit.edu Git - ikiwiki.git/commitdiff
fix rcs_prepedit implementation to match spec
authorJoey Hess <joey@kitenet.net>
Fri, 8 Oct 2010 22:02:47 +0000 (18:02 -0400)
committerJoey Hess <joey@kitenet.net>
Fri, 8 Oct 2010 22:02:47 +0000 (18:02 -0400)
IkiWiki/Plugin/git.pm
IkiWiki/Plugin/recentchanges.pm

index 996ab6fba0f5e6076c3a793d4ec06ef57ec93b6f..48e71aa9aedfcf897996fa7d032d054af52717dc 100644 (file)
@@ -836,19 +836,15 @@ sub rcs_receive () {
        return reverse @rets;
 }
 
-sub rcs_preprevert (@) {
-       my %params = @_;
-       my $rev = $params{rev};
-
-       # Note test_changes expects 'cgi' and 'session' parameters.
-       require IkiWiki::Receive;
-       IkiWiki::Receive::test_changes(%params, changes =>
-               [git_parse_changes(git_commit_info($rev, 1))]);
+sub rcs_preprevert ($) {
+       my $rev=shift;
+
+       return git_parse_changes(git_commit_info($rev, 1));
 }
 
 sub rcs_revert ($) {
        # Try to revert the given rev; returns undef on _success_.
-       my $rev = $shift;
+       my $rev = shift;
 
        if (run_or_non('git', 'revert', '--no-commit', $rev)) {
                return undef;
index a6d7f9fcefd98b4392cd4dcbd955c7225cde0e87..56e17dcca4035b5d668cfd4b6d69e048c559a143 100644 (file)
@@ -93,8 +93,13 @@ sub sessioncgi ($$) {
 
        return unless $do eq 'revert' && $rev;
 
-       $IkiWiki::hooks{rcs}{rcs_preprevert}{call}->(
-               cgi => $q, session => $session, rev => $rev);
+       my @changes=$IkiWiki::hooks{rcs}{rcs_preprevert}{call}->($rev);
+       require IkiWiki::Receive;
+       IkiWiki::Receive::test_changes(
+               cgi => $q,
+               session => $session,
+               changes => \@changes,
+       );
 
        my ($form, $buttons) = confirmation_form($q, $session);
        IkiWiki::decode_form_utf8($form);