Add full parser for git diff-tree output
authorBrian Downing <bdowning@lavos.net>
Thu, 17 Jan 2008 12:42:34 +0000 (06:42 -0600)
committerJoey Hess <joey@kodama.kitenet.net>
Thu, 17 Jan 2008 16:15:23 +0000 (11:15 -0500)
The -c option to git log/diff-tree produces "merged" diffs with a
different format from normal ones.  However, the existing diff-tree
parser only accepted non-merged diff lines.  Merged diff lines caused
the parser to get out of sync.  This patch adds a full parser for diffs
with any number of parents.  See the "DIFF FORMAT FOR MERGES" section in
the git-diff-tree man page for more information.

Signed-off-by: Brian Downing <bdowning@lavos.net>
IkiWiki/Rcs/git.pm

index d4d2ec7a943b7c2fd6639dc25555947e3b5ad467..fea1c11eb4a9c9f7d599c863abbfa13ebfcaa179 100644 (file)
@@ -217,17 +217,19 @@ sub _parse_diff_tree ($@) { #{{{
 
        # Modified files.
        while (my $line = shift @{ $dt_ref }) {
 
        # Modified files.
        while (my $line = shift @{ $dt_ref }) {
-               if ($line =~ m{^:
-                       ([0-7]{6})[ ]      # from mode
-                       ([0-7]{6})[ ]      # to mode
-                       ($sha1_pattern)[ ] # from sha1
-                       ($sha1_pattern)[ ] # to sha1
-                       (.)                # status
-                       ([0-9]{0,3})\t     # similarity
-                       (.*)               # file
+               if ($line =~ m{^
+                       (:+)       # number of parents
+                       ([^\t]+)\t # modes, sha1, status
+                       (.*)       # file names
                $}xo) {
                $}xo) {
-                       my ($sha1_from, $sha1_to, $file) =
-                          ($3,         $4,       $7   );
+                       my $num_parents = length $1;
+                       my @tmp = split(" ", $2);
+                       my ($file, $file_to) = split("\t", $3);
+                       my @mode_from = splice(@tmp, 0, $num_parents);
+                       my $mode_to = shift(@tmp);
+                       my @sha1_from = splice(@tmp, 0, $num_parents);
+                       my $sha1_to = shift(@tmp);
+                       my $status = shift(@tmp);
 
                        if ($file =~ m/^"(.*)"$/) {
                                ($file=$1) =~ s/\\([0-7]{1,3})/chr(oct($1))/eg;
 
                        if ($file =~ m/^"(.*)"$/) {
                                ($file=$1) =~ s/\\([0-7]{1,3})/chr(oct($1))/eg;
@@ -236,7 +238,7 @@ sub _parse_diff_tree ($@) { #{{{
                        if (length $file) {
                                push @{ $ci{'details'} }, {
                                        'file'      => decode_utf8($file),
                        if (length $file) {
                                push @{ $ci{'details'} }, {
                                        'file'      => decode_utf8($file),
-                                       'sha1_from' => $sha1_from,
+                                       'sha1_from' => $sha1_from[0],
                                        'sha1_to'   => $sha1_to,
                                };
                        }
                                        'sha1_to'   => $sha1_to,
                                };
                        }