]> sipb.mit.edu Git - ikiwiki.git/commitdiff
Comment: this patch doesn't work correctly.
authorhttp://lj.rossia.org/users/imz/ <http://lj.rossia.org/users/imz/@web>
Thu, 14 May 2009 15:06:49 +0000 (11:06 -0400)
committerJoey Hess <joey@kitenet.net>
Thu, 14 May 2009 15:06:49 +0000 (11:06 -0400)
doc/todo/auto-create_tag_pages_according_to_a_template.mdwn

index 30a217413a9d4b1d28161af59fda7e012ce228cf..87b30891efdd9d2460ea5c225e17b94f8bcbe5cc 100644 (file)
@@ -106,3 +106,20 @@ I am not sure if that is the best way to handle it.
 
 [[!tag patch]]
 -- Jeremy Schultz <jeremy.schultz@uleth.ca>
+
+No, this doesn't help:
+
+       +       # This refresh/saveindex is to fix the Tags link
+       +       # With out this additional refresh/saveindex the tag link displays ?tag
+       +       IkiWiki::refresh();
+       +       IkiWiki::saveindex();
+
+On the second extra pass, it doesn't notice that it has to update the "?"-link. If I run ikiwiki once more, it is updated. I don't know yet how this should be fixed, because I don't know the internals of ikiwiki good enough. Something inhibits detecting the need to update in refresh() in Render.pm; perhaps, this condition: 
+
+               if (! $pagemtime{$page}) {
+                   ...
+                               push @add, $file;
+                   ...
+                }
+
+is not satisfied for the newly created tag page. I shall put debug msgs into Render.pm to find out better how it works. --Ivan Z.