From: Joey Hess Date: Thu, 16 Dec 2010 18:08:32 +0000 (-0400) Subject: response X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/commitdiff_plain/02056f7792b3fb2f7b6cd099325243fe0ad53e82?ds=sidebyside response --- diff --git a/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn b/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn index d40be0b08..88c82f66c 100644 --- a/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn +++ b/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn @@ -27,6 +27,8 @@ and decided this time it was really needed to implement this feature. >> (I'm not an ikiwiki committer, opinions may vary.) >> +>>> In my opinion, you're an ikiwiki committer! --[[Joey]] +>> >> This would be easier to review if there weren't a million merges from >> master; perhaps either leave a branch as-is, or rebase it, or merge >> only at "significant" times like after a release? @@ -59,3 +61,14 @@ and decided this time it was really needed to implement this feature. >>> the future, though. >>> >>> --[[intrigeri]] + +>>>> FWIW, I don't care about merge commits etc because I review +>>>> `git diff ...intrigeri/mirrorlist` -- and if I want to dig deeper +>>>> into the why of some code, I'll probably checkout the branch and +>>>> use git blame. +>>>> +>>>> I agree with what smcv said, my other concern though is that +>>>> this is such an edge case, that supporting it just adds clutter. +>>>> Have to wonder if it wouldn't perhaps be better to do something +>>>> using the goto plugin and cgiurl, so that the mirror doesn't have +>>>> to know about the configuration of the other mirror. --[[Joey]]