From: Amitai Schlair Date: Wed, 7 Jan 2015 23:25:21 +0000 (-0500) Subject: Mention schmonz/comments-anonymous-url-vcs X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/commitdiff_plain/50fba5d84432cd27c4a02e61c9ed5e03aa10ae30 Mention schmonz/comments-anonymous-url-vcs --- diff --git a/doc/plugins/comments/discussion.mdwn b/doc/plugins/comments/discussion.mdwn index 2b8add938..0e5c5e669 100644 --- a/doc/plugins/comments/discussion.mdwn +++ b/doc/plugins/comments/discussion.mdwn @@ -230,3 +230,24 @@ Any suggestions or hints how to implement this? > I've implemented this. See [[todo/Restrict_formats_allowed_for_comments]]. > --[[wentasah]] + +## URLs in anonymous-style comments committed directly via VCS + +[[!template id=gitbranch branch=schmonz/comments-anonymous-url-vcs author="[[schmonz]]"]] + +I recently imported my site from Textpattern into ikiwiki (using +an `ikiwiki-import` program that may someday make its way into +ikiwiki proper). Textpattern's comments behave much like ikiwiki's +anonymous comments, so piping each imported comment through +`ikiwiki-comment` and regenerating the site with `comments_allowauthor=1` +preserved almost all the information. + +What's missing: if a comment directive has a `url` param, I'd expect +the rendered page to href the author's name to that URL. This works +as I expect for new comments added via the CGI, but not for imported +comments added via the VCS directly. + +My branch has a fix that doesn't break `t/comments.t`, doesn't +appear to break anonymous or signed-in comments via the CGI in any +way I've tried, and lets me render my (incredibly valuable ;-) +imported blog comments with full fidelity. OK to commit?