From: Joey Hess <joey@kitenet.net>
Date: Sun, 4 Jul 2010 18:22:19 +0000 (-0400)
Subject: review of needstranslation() pagespec
X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/commitdiff_plain/8a8914151cee44592dfdc3df3bb2c45b19b8c29c

review of needstranslation() pagespec

Minor wording fix; changelog; etc.
---

diff --git a/IkiWiki/Plugin/po.pm b/IkiWiki/Plugin/po.pm
index f12c69d5f..0b2251668 100644
--- a/IkiWiki/Plugin/po.pm
+++ b/IkiWiki/Plugin/po.pm
@@ -1225,7 +1225,7 @@ sub match_needstranslation ($$;@) {
 
 	my $percenttranslated=IkiWiki::Plugin::po::percenttranslated($page);
 	if ($percenttranslated eq 'N/A') {
-		return IkiWiki::FailReason->new("file is not a translation page");
+		return IkiWiki::FailReason->new("file is not a translatable page");
 	}
 	elsif ($percenttranslated < 100) {
 		return IkiWiki::SuccessReason->new("file has $percenttranslated translated");
diff --git a/debian/changelog b/debian/changelog
index 7d857d9c0..bdcf52884 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -20,6 +20,7 @@ ikiwiki (3.20100624) UNRELEASED; urgency=low
   * git: Added git_wrapper_background_command option. Can be used to eg, 
     make the git wrapper push to github in the background after ikiwiki
     runs.
+  * po: Added needstranslation() pagespec. (intrigeri)
 
  -- Joey Hess <joeyh@debian.org>  Wed, 23 Jun 2010 15:30:04 -0400
 
diff --git a/doc/todo/po_needstranslation_pagespec.mdwn b/doc/todo/po_needstranslation_pagespec.mdwn
index acc5641a4..77449dc2b 100644
--- a/doc/todo/po_needstranslation_pagespec.mdwn
+++ b/doc/todo/po_needstranslation_pagespec.mdwn
@@ -2,4 +2,8 @@ Commit b225fdc44d4b3d in my po branch adds a `needstranslation()`
 PageSpec. It makes it easy to list pages that need translation work.
 Please review. --[[intrigeri]]
 
-[[!tag patch]]
+> Looks good, cherry-picked. The only improvment I can 
+> think of is that `needstranslation(50)` could match
+> only pages less than 50% translated. --[[Joey]] 
+
+[[!tag patch done]]