From: Joey Hess Date: Mon, 5 Sep 2011 17:49:37 +0000 (-0400) Subject: code review X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/commitdiff_plain/a4fe34affb6ff507de55fc6cade3f43be3100bd8 code review --- diff --git a/doc/todo/allow_site-wide_meta_definitions.mdwn b/doc/todo/allow_site-wide_meta_definitions.mdwn index a308e0d8c..d1034bf58 100644 --- a/doc/todo/allow_site-wide_meta_definitions.mdwn +++ b/doc/todo/allow_site-wide_meta_definitions.mdwn @@ -83,6 +83,8 @@ definitions essentially. >> >>> I generally agree with this. It is *possible* that meta would have a new >>> field added, that takes parameters and make sense to use globally. +>>> (Indeed, this later happened to some extent with the sortas parameters +>>> being added to some metas.) >>> --[[Joey]] >> >> Due to this, and the added complexity of the second patch (having to adjust @@ -150,3 +152,8 @@ definitions essentially. >>>>> >>>>> The patch can be found at the git branch described above. >>>>> — [[Jon]] + +>>>>>> I wish I could take pity on you and just merge this, but +>>>>>> AFAICS it still suffers from the memory bloat described above. +>>>>>> Specifically, when `scan` calls `preprocess`, it +>>>>>> stores the metadata in `%pagestate` etc. --[[Joey]]