From: Joey Hess <joey@kitenet.net>
Date: Sat, 20 Nov 2010 16:25:52 +0000 (-0400)
Subject: avoid an unnecessary hash lookup
X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/commitdiff_plain/b3bca318ef11ce9d0609d952a72849243b591b9d

avoid an unnecessary hash lookup
---

diff --git a/IkiWiki.pm b/IkiWiki.pm
index e5370f4a6..f57ef8c6c 100644
--- a/IkiWiki.pm
+++ b/IkiWiki.pm
@@ -2493,11 +2493,11 @@ sub match_glob ($$;@) {
 
 	# Instead of converting the glob to a regex every time,
 	# cache the compiled regex to save time.
-	if (!defined $glob_cache{$glob}) {
-		my $re = IkiWiki::glob2re($glob);
-		$glob_cache{$glob} = $re;
+	my $re=$glob_cache{$glob};
+	unless (defined $re) {
+		$glob_cache{$glob} = $re = IkiWiki::glob2re($glob);
 	}
-	if ($page=~ $glob_cache{$glob}) {
+	if ($page =~ $re) {
 		if (! IkiWiki::isinternal($page) || $params{internal}) {
 			return IkiWiki::SuccessReason->new("$glob matches $page");
 		}