From: joey Date: Tue, 20 Feb 2007 16:35:58 +0000 (+0000) Subject: web commit by tuomov: Counter-review X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/commitdiff_plain/b74c51b8ec5d6e534432b13588bdda1521454180?ds=sidebyside web commit by tuomov: Counter-review --- diff --git a/doc/patchqueue/index.html_allowed.mdwn b/doc/patchqueue/index.html_allowed.mdwn index 5904b6096..039c6cda1 100644 --- a/doc/patchqueue/index.html_allowed.mdwn +++ b/doc/patchqueue/index.html_allowed.mdwn @@ -407,6 +407,16 @@ Index: linkmap.pm } + > This is probably supposed to be `$mapitems{$item}=urlto($item, $params{destpage});`, + > which does indeed remove one more `htmlpage` call from the plugins. I can't actually + > try it: "failed writing to dst/ts.png.ikiwiki-new: Inappropriate ioctl for device". + > After this probable fix, in fact, all uses of htmlpage in the plugins are used to + > construct an absolute address: the absolute url in most cases, so an `absurl` + > call could be added to be used instead of htmlpage, and something else in the + > aggregate plugin (above), that I also think isn't what's wanted: + > aren't `foo.html` pages also "rendered", so that they get moved as `foo/index.html`? + > --[[tuomov]] + * `inline.pm` uses htmlpage and `abs2rel` to generate a link, and probably needs to be changed to either use `urlto` or to call `beautify_url` like htmllink does. This might work: