From: joey Date: Wed, 25 Jul 2007 02:27:23 +0000 (+0000) Subject: triage X-Git-Url: https://sipb.mit.edu/gitweb.cgi/ikiwiki.git/commitdiff_plain/de9104d4e2571dcdf28659b3fd244c3c77f02740?ds=sidebyside triage --- diff --git a/doc/bugs/A_page_that_inlines_pages__61____34____42____34___results_in_unnecessary_feed_generation.mdwn b/doc/bugs/A_page_that_inlines_pages__61____34____42____34___results_in_unnecessary_feed_generation.mdwn deleted file mode 100644 index 0f623828a..000000000 --- a/doc/bugs/A_page_that_inlines_pages__61____34____42____34___results_in_unnecessary_feed_generation.mdwn +++ /dev/null @@ -1,74 +0,0 @@ -I noticed when generating my wiki that all of my RSS feeds were -getting regenerated even when I edited only a page that did not affect -any feed. - -I found that the problem only occurs in the presence of a file that -contains \[[inline pages="*"]]. - -> How is this unexpected? By inlining _every_ page in the wiki, you're -> making that page depend on every other page; any change to any page in -> the wiki will result in the inlining page and its rss feed needing to be -> updated to include the changed page. -> --[[Joey]] - -Here's a short script for replicating the bug. Just cut and paste this -to a shell, (it will only muck in a new /tmp/ikiwiki-test directory -that it will create): - - cd /tmp - mkdir ikiwiki-test; cd ikiwiki-test; mkdir src - echo '\[[inline pages="blog/*"]]' > src/myblog.mdwn - mkdir src/blog; echo "A blog entry" > src/blog/entry.mdwn - echo 'use IkiWiki::Setup::Standard { - srcdir => "src", - destdir => "output", - url => "http://example.com", - templatedir => "/dev/null", - underlaydir => "/dev/null", - rss => 1, - wrappers => [], - verbose => 1, - refresh => 1 - }' > setup - ikiwiki --setup setup - ls -l --time-style=full-iso output/myblog/index.rss - echo "not a blog entry" > src/not-a-blog.mdwn - ikiwiki --setup setup - ls -l --time-style=full-iso output/myblog/index.rss - echo '\[[inline pages="*"]]' > src/archives.mdwn - ikiwiki --setup setup - ls -l --time-style=full-iso output/myblog/index.rss - echo "still not blogging" >> src/not-a-blog.mdwn - ikiwiki --setup setup - ls -l --time-style=full-iso output/myblog/index.rss - -Here's the tail of the output that I see for this command: - - $ echo "not a blog entry" > src/not-a-blog.mdwn - $ ikiwiki --setup setup - refreshing wiki.. - scanning not-a-blog.mdwn - rendering not-a-blog.mdwn - done - $ ls -l --time-style=full-iso output/myblog/index.rss - -rw-r--r-- 1 cworth cworth 459 2007-06-01 06:34:36.000000000 -0700 output/myblog/index.rss - $ echo '\[[inline pages="*"]]' > src/archives.mdwn - $ ikiwiki --setup setup - refreshing wiki.. - scanning archives.mdwn - rendering archives.mdwn - done - $ ls -l --time-style=full-iso output/myblog/index.rss - -rw-r--r-- 1 cworth cworth 459 2007-06-01 06:34:37.000000000 -0700 output/myblog/index.rss - $ echo "still not blogging" >> src/not-a-blog.mdwn - $ ikiwiki --setup setup - refreshing wiki.. - scanning not-a-blog.mdwn - rendering not-a-blog.mdwn - rendering archives.mdwn, which depends on not-a-blog - done - $ ls -l --time-style=full-iso output/myblog/index.rss - -rw-r--r-- 1 cworth cworth 459 2007-06-01 06:34:38.000000000 -0700 output/myblog/index.rss - -It looks like the rendering of archives.mdwn is also silently -generating myblog/index.rss. diff --git a/doc/bugs/Command-line_arguments_should_override_settings_in_the_setup_file.mdwn b/doc/bugs/Command-line_arguments_should_override_settings_in_the_setup_file.mdwn index 36387a8c9..c93cdc6ad 100644 --- a/doc/bugs/Command-line_arguments_should_override_settings_in_the_setup_file.mdwn +++ b/doc/bugs/Command-line_arguments_should_override_settings_in_the_setup_file.mdwn @@ -16,8 +16,13 @@ So two suggestions to fix this: 1. Make command-line arguments override settings in the setup file +> This is difficult to do, since reading a setup file replaces values for +> config items with the values in the setup file. + 2. Comment out all settings in the example setup file that are simply setting options to their default values. That way, the file will still be self-documenting, but command-line arguments will at least work for these settings while they remain commented out. +> I've done that, I also fixed some issues with --verbose handling earlier. +> --[[Joey]] diff --git a/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn b/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn index 201d7fbec..28b48e2c6 100644 --- a/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn +++ b/doc/bugs/Insecure_dependency_in_eval_while_running_with_-T_switch.mdwn @@ -90,4 +90,9 @@ to break the code I distribute in my backport ;) >> BTW, I was quite sure that you sent me the old patch via e-mail long time ago. >> Maybe I found it at old ikiwiki home page? I don't remember it now. >> ->> --[[Paweł|ptecza]] \ No newline at end of file +>> --[[Paweł|ptecza]] + +---- + +I'm marking this [[done]] since it only affects sarge. Sarge users should +use the patch above. --[[Joey]] diff --git a/doc/bugs/disabling_backlinks.mdwn b/doc/bugs/disabling_backlinks.mdwn index 0a1963bc3..74b25f0f0 100644 --- a/doc/bugs/disabling_backlinks.mdwn +++ b/doc/bugs/disabling_backlinks.mdwn @@ -10,4 +10,5 @@ My first reading (and second and third) of this was that backlinks would be disa --[[KarlMW]] > Yes, it only controls the number of backlinks that are shown at the -> bottom of the page vs how many are moved to the popup --[[Joey]] +> bottom of the page vs how many are moved to the popup. I've tried to +> improve the documentation for this. [[done]] --[[Joey]] diff --git a/doc/bugs/index.html__63__updated.mdwn b/doc/bugs/index.html__63__updated.mdwn index 84aac9b59..e56bd7941 100644 --- a/doc/bugs/index.html__63__updated.mdwn +++ b/doc/bugs/index.html__63__updated.mdwn @@ -1 +1,15 @@ -After editing a page `pagename`, ikiwiki redirects to `pagename/index.html?updated`. Ignoring for the moment that ?updated seems like a bad idea to begin with, this should at least not introduce /index.html into the URL. \ No newline at end of file +After editing a page `pagename`, ikiwiki redirects to `pagename/index.html?updated`. Ignoring for the moment that ?updated seems like a bad idea to begin with, this should at least not introduce /index.html into the URL. + +> The "?updated" works around caching issues with certain broken browsers, +> web proxys, and/or webservers. These assume that since the "?" is there, +> the page is not static, or is a different page, thus forcing the page to +> be reloaded and the edited version seen. So no, not a bad idea, really. +> +> Removing the index.html would probably break this workaround. +> http://foo/bar/?updated will redirect to http://foo/bar/index.html, and +> said broken software will then display its old out of date cached +> version. +> +> So, not changing this. [[tag done]] +> +> --[[Joey]]