From 013a5e4ca74108bf9206be25d3ffdad985ce266f Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 30 Jan 2009 15:17:53 -0500 Subject: [PATCH] formatting --- doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn b/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn index 48fd7c647..cdd8a03b1 100644 --- a/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn +++ b/doc/bugs/pagetitle_function_does_not_respect_meta_titles.mdwn @@ -162,14 +162,14 @@ So, looking at your meta branch: --[[Joey]] 1) It needs the full page name, not basename. 2) `titlepage(pagetitle($page))` reversability. - #1: If you look at all the callers + 1) If you look at all the callers Of `pagetitle` most of them pass a complete page name, not just the basename. In most cases `pagetitle` is used to display the full name of the page, including any subdirectory it's in. So why not just make it consitently be given the full name of the page, with another argument specifying if we want to get back just the base name. - #2: I can't find any code that actually uses the reversability like that. + 2) I can't find any code that actually uses the reversability like that. The value passed to `titlepage` always comes from some external source. Unless I missed one. * The use of `File::Spec->rel2abs` is a bit scary. -- 2.45.0