From 09e7c1ad99367eb00d56cfc1e6c64e9b0e361dc4 Mon Sep 17 00:00:00 2001 From: Amitai Schlair Date: Wed, 15 Oct 2014 23:52:43 +0100 Subject: [PATCH] IkiWiki::Plugin::openid: as a precaution, do not call non-coderefs We're running under "use strict" here, so if CGI->param's array-context misbehaviour passes an extra non-ref parameter, it shouldn't be executed anyway... but it's as well to be safe. [commit message added by smcv] --- IkiWiki/Plugin/openid.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/IkiWiki/Plugin/openid.pm b/IkiWiki/Plugin/openid.pm index 63112d983..384af7e98 100644 --- a/IkiWiki/Plugin/openid.pm +++ b/IkiWiki/Plugin/openid.pm @@ -119,7 +119,9 @@ sub validate ($$$;$) { my $claimed_identity = $csr->claimed_identity($openid_url); if (! $claimed_identity) { if ($errhandler) { - $errhandler->($csr->err); + if (ref($errhandler) eq 'CODE') { + $errhandler->($csr->err); + } return 0; } else { -- 2.44.0