From 54cfc8936525f7964e8720dab77fefd84002d57f Mon Sep 17 00:00:00 2001 From: Amitai Schlair Date: Fri, 19 Jul 2013 11:22:42 -0400 Subject: [PATCH] I think this branch is now ready to merge. --- doc/todo/fancypodcast.mdwn | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/doc/todo/fancypodcast.mdwn b/doc/todo/fancypodcast.mdwn index 31b6c44f9..79b214049 100644 --- a/doc/todo/fancypodcast.mdwn +++ b/doc/todo/fancypodcast.mdwn @@ -12,11 +12,8 @@ also have lots more metadata. In summary, the branch preserves ikiwiki's existing podcast behavior, adds more featureful behavior, and has been tested to work well in -some common podcatchers. I believe it is ready for review and -possible integration, and I'd like to get feedback to that effect -(or to the contrary) before making further enhancements. I know -[[joey]]'s the final arbiter here, but I'd appreciate any qualified, -critical eyes ([[smcv]]?) raking over my diffs. --[[schmonz]] +some common podcatchers. I believe it is ready for integration. +--[[schmonz]] ## Features @@ -73,6 +70,11 @@ Episode enclosure |(./) |(./) |(./) |(./) display details against a reference podcast. * Verify smooth transitions for two common use cases (see testing details below). +* Code review: don't add enclosure divs unless we have enclosures. +* Code review: genericize download link for more use cases. +* Code review: don't confuse old readers with Atom names in RSS. +* Code review: instead of hacking back to `$link`, just provide it. +* Code review: show author in addition to feedname, if different. ### Must-have (for [[schmonz]], anyway) @@ -312,10 +314,10 @@ could negatively impact eg, Planet style aggregators using ikiwiki. --[[Joey]] >>>> when I generate the same planet as updo and run `r2e` over it, >>>> the names I get in `From:` look like so: - "updo: Junio C Hamano" - "updo: Greg Kroah-Hartman" - "updo: Eric Raymond: esr"` (article author != feed name, so we get both) - "updo: Jannis Pohlman: Jannis Pohlmann"` (oops! I tweaked the real updo) +* `"updo: Junio C Hamano"` +* `"updo: Greg Kroah-Hartman"` +* `"updo: Eric Raymond: esr"` (article author != feed name, so we get both) +* `"updo: Jannis Pohlman: Jannis Pohlmann"` (oops! I tweaked the real updo) >>>> --[[schmonz]] -- 2.44.0