From 6b6d330bade5244b4457405cd144f5bf2f9de0ae Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Tue, 6 Jan 2015 00:26:41 +0000 Subject: [PATCH] textile-double-escape-bug.t: tolerate any valid encoding MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Discount in current Debian unstable turns the IURI href into a URI by encoding the Unicode as UTF-8 and %-escaping each byte. That is valid, and matches Wikipedia's expectations, but was breaking this test for me. It would also be entirely valid (and lead to equivalent parsing) if the ö was represented as ö, ö or ö in the text and/or the href. --- t/textile-double-escape-bug.t | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/t/textile-double-escape-bug.t b/t/textile-double-escape-bug.t index 607706be4..f8ab3f7e1 100755 --- a/t/textile-double-escape-bug.t +++ b/t/textile-double-escape-bug.t @@ -14,20 +14,22 @@ BEGIN { subtest 'Text::Textile apparently double-escapes HTML entities in hrefs' => sub { my $text = q{Gödel, Escher, Bach}; + my $text_ok = qr{G(?:ö|ö|ö|&#x[fF]6;)del, Escher, Bach}; my $href = q{https://en.wikipedia.org/wiki/Gödel,_Escher,_Bach}; - my $good = qq{

$text

}; + my $href_ok = qr{https://en\.wikipedia\.org/wiki/G(?:ö|ö|ö|&#x[fF]6|%[cC]3%[bB]6)del,_Escher,_Bach}; + my $good = qr{

$text_ok

}; chomp(my $mdwn_html = IkiWiki::Plugin::mdwn::htmlize( content => qq{[$text]($href)}, )); - is($mdwn_html, $good); + like($mdwn_html, $good); chomp(my $txtl_html = IkiWiki::Plugin::textile::htmlize( content => qq{"$text":$href}, )); TODO: { local $TODO = "Text::Textile double-escapes the href"; - is($txtl_html, $good); - isnt($txtl_html, q{

Gödel, Escher, Bach

}); + like($txtl_html, $good); + unlike($txtl_html, qr{

Gödel, Escher, Bach

}i); } }; -- 2.45.0