From dfc8fa9f8e257d103125dd20b15040c584d833f8 Mon Sep 17 00:00:00 2001 From: "https://id.koumbit.net/anarcat" Date: Sat, 3 Mar 2012 17:29:31 -0400 Subject: [PATCH 1/1] fix the diff button location --- doc/todo/provide_inline_diffs_in_recentchanges.mdwn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/todo/provide_inline_diffs_in_recentchanges.mdwn b/doc/todo/provide_inline_diffs_in_recentchanges.mdwn index ed9dd85fd..7e95791c6 100644 --- a/doc/todo/provide_inline_diffs_in_recentchanges.mdwn +++ b/doc/todo/provide_inline_diffs_in_recentchanges.mdwn @@ -13,7 +13,7 @@ It would rock if I could view diffs from the web without going via feeds. I envi > > > > 1. it assumes the toggle.js code is loaded somehow > > 2. if the toggle code isn't loaded the diffs are displayed (which is arguably better than showing nothing since we ship the diff to the UA anyways...) -> > 3. it will show only if there's a revert URL, which is backwards, but otherwise the display is weird, with each button on its own line +> > 3. it will show only if there's a revert URL, which is backwards, but otherwise the display is weird, with each button on its own line fixed! > > 4. if the diffurl parameter is set in the template, we'd actually see two sets of glasses, which is silly. > > > > I feel this should nevertheless be implemented because if we're going to compile all this crap in the page anyways and send it to the client, why not allow the user to show it? I also feel that showing it by default is a lesser evil for non-javascript users. -- 2.45.0