From e4e53d7a18ec18d1ba72b1a4f124e211148e0f12 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 2 Apr 2010 22:23:36 -0400 Subject: [PATCH 1/1] response --- doc/todo/matching_different_kinds_of_links.mdwn | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/todo/matching_different_kinds_of_links.mdwn b/doc/todo/matching_different_kinds_of_links.mdwn index 4f52ade52..2cd484852 100644 --- a/doc/todo/matching_different_kinds_of_links.mdwn +++ b/doc/todo/matching_different_kinds_of_links.mdwn @@ -104,6 +104,8 @@ Some code refers to `oldtypedlinks`, and other to `oldlinktypes`. --[[Joey]] > Oops, I'll fix that. That must mean missing test coverage, too :-( > --s +>> A test suite for the dependency resolver *would* be nice. --[[Joey]] + I'm curious what your reasoning was for adding a new variable rather than using `pagestate`. Was it only because you needed the `old` version to detect change, or was there other complexity? @@ -133,6 +135,8 @@ with a empty type. (Bloaty.)) --J > not counting tags and other typed links?". A typed link is > still a link, in my mind at least. --s +>> Me neither, let's not worry about it. --[[Joey]] + I suspect we could get away without having `tagged_is_strict` without too much transitional trouble. --[[Joey]] @@ -149,3 +153,6 @@ to set that link type, and its own pagespec function to match it. I wonder whether to make a `typedlink` plugin that has the typedlink pagespec match function and a new `\[[!typedlink to="foo" type="bar"]]` though... --[[smcv]] + +> I agree, per-type matchers are more friendly and I'm not enamored of the +> multi-parameter pagespec syntax. --[[Joey]] -- 2.44.0