From ea5da191899d5c8b9cc225ec014bd7f6c7490b79 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 4 Jun 2008 15:00:24 -0400 Subject: [PATCH] fix uninitialized value problem This occurred when a plugin, loaded earlier, filled out a template in its checkconfig, before recentchanges's checkconfig had run. Since such a template won't be a recentchanges template, just test for the value being uninitialized and skip processing. --- IkiWiki/Plugin/recentchanges.pm | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/IkiWiki/Plugin/recentchanges.pm b/IkiWiki/Plugin/recentchanges.pm index 3020b6a6a..f4f9ca348 100644 --- a/IkiWiki/Plugin/recentchanges.pm +++ b/IkiWiki/Plugin/recentchanges.pm @@ -40,14 +40,8 @@ sub pagetemplate (@) { #{{{ my $template=$params{template}; my $page=$params{page}; - # XXX this is here because I've been seeing a strange uninitialized - # value in this sub. - if (! defined $config{recentchangespage}) { - eval q{use Carp}; - Carp::cluck("undefined recentchangespage; please report this to Joey"); - } - - if ($config{rcs} && $page ne $config{recentchangespage} && + if (defined $config{recentchangespage} && $config{rcs} && + $page ne $config{recentchangespage} && $template->query(name => "recentchangesurl")) { $template->param(recentchangesurl => urlto($config{recentchangespage}, $page)); $template->param(have_actions => 1); -- 2.44.0