1 [[!tag plugins/meta patch]]
2 [[!template id=gitbranch branch=jon/defaultmeta author="[[Jon]]"]]
4 I'd like to define [[plugins/meta]] values to apply across all pages
5 site-wide unless the pages define their own: default values for meta
6 definitions essentially.
8 <snip old patch, see below for latest>
12 > This doesn't support multiple-argument meta directives like
13 > `link=x rel=y`, or meta directives with special side-effects like
16 > The first could be solved (if you care) by a syntax like this:
19 > { copyright => "© me" },
20 > { link => "about:blank", rel => "silly", },
23 > The second could perhaps be solved by invoking `meta::preprocess` from within
24 > `scan` (which might be a simplification anyway), although this is complicated
25 > by the fact that some (but not all!) meta headers are idempotent.
29 >> Thanks for your comment. I've revised the patch to use the config syntax
30 >> you suggest. I need to perform some more testing to make sure I've
31 >> addressed the issues you highlight.
33 >> I had to patch part of IkiWiki core, the merge routine in Setup, because
34 >> the use of `possibly_foolish_untaint` was causing the hashrefs at the deep
35 >> end of the data structure to be converted into strings. The specific change
36 >> I've made may not be acceptable, though -- I'd appreciate someone providing
37 >> some feedback on that hunk!
39 diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm
40 index 6fe9cda..c4079fd 100644
41 --- a/IkiWiki/Plugin/meta.pm
42 +++ b/IkiWiki/Plugin/meta.pm
43 @@ -13,6 +13,7 @@ sub import {
44 hook(type => "needsbuild", id => "meta", call => \&needsbuild);
45 hook(type => "preprocess", id => "meta", call => \&preprocess, scan => 1);
46 hook(type => "pagetemplate", id => "meta", call => \&pagetemplate);
47 + hook(type => "scan", id => "meta", call => \&scan);
51 @@ -305,6 +306,17 @@ sub match {
57 + my $page = $params{page};
58 + if($config{"meta_defaults"}) {
59 + foreach my $default (@{$config{"meta_defaults"}}) {
60 + preprocess(%$default, page => $page,
61 + destpage => $page, preview => 0);
66 package IkiWiki::PageSpec;
68 sub match_title ($$;@) {
69 diff --git a/IkiWiki/Setup.pm b/IkiWiki/Setup.pm
70 index 8a25ecc..e4d50c9 100644
71 --- a/IkiWiki/Setup.pm
72 +++ b/IkiWiki/Setup.pm
73 @@ -51,7 +51,13 @@ sub merge ($) {
74 $config{$c}=$setup{$c};
77 - $config{$c}=[map { IkiWiki::possibly_foolish_untaint($_) } @{$setup{$c}}]
79 + if(ref $_ eq 'HASH') {
82 + IkiWiki::possibly_foolish_untaint($_)
87 elsif (ref $setup{$c} eq 'HASH') {
88 diff --git a/doc/ikiwiki/directive/meta.mdwn b/doc/ikiwiki/directive/meta.mdwn
89 index 000f461..8d34ee4 100644
90 --- a/doc/ikiwiki/directive/meta.mdwn
91 +++ b/doc/ikiwiki/directive/meta.mdwn
92 @@ -12,6 +12,16 @@ also specifies some additional sub-parameters.
93 The field values are treated as HTML entity-escaped text, so you can include
94 a quote in the text by writing `"` and so on.
96 +You can also define site-wide defaults for meta values by including them
97 +in your setup file. The key used is `meta_defaults` and the value is a list
98 +of hashes, one per meta directive. e.g.:
101 + { copyright => "Copyright 2007 by Joey Hess" },
102 + { license => "GPL v2+" },
103 + { link => "somepage", rel => "site entrypoint", },