minor style etc changes

[ikiwiki.git] / IkiWiki / Plugin / meta.pm

diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm
index cd7d0d1277a47d4fcdd889961e81204d2a470010..892f6b2c96a46e93e610a1690d5f19ffa50b7703 100644 (file)
--- a/IkiWiki/Plugin/meta.pm
+++ b/IkiWiki/Plugin/meta.pm
@@ -88,13 +88,18 @@ sub preprocess (@) {
 
        # Metadata collection that needs to happen during the scan pass.
        if ($key eq 'title') {
 
        # Metadata collection that needs to happen during the scan pass.
        if ($key eq 'title') {

-               $pagestate{$page}{meta}{title}=HTML::Entities::encode_numeric($value);
-               if (exists $params{sort}) {
-                       $pagestate{$page}{meta}{titlesort}=$params{sort};
+               my $encoded = HTML::Entities::encode_numeric($value);
+               $pagestate{$page}{meta}{title} = $encoded;
+
+               if (exists $params{sortas}) {
+                       $pagestate{$page}{meta}{titlesort}=$params{sortas};

                }
                }

-               else {
+               elsif ($encoded ne $value) {

                        $pagestate{$page}{meta}{titlesort}=$value;
                }
                        $pagestate{$page}{meta}{titlesort}=$value;
                }

+               else {
+                       delete $pagestate{$page}{meta}{titlesort};
+               }

                return "";
        }
        elsif ($key eq 'description') {
                return "";
        }
        elsif ($key eq 'description') {


@@ -122,6 +127,12 @@ sub preprocess (@) {
        }
        elsif ($key eq 'author') {
                $pagestate{$page}{meta}{author}=$value;
        }
        elsif ($key eq 'author') {
                $pagestate{$page}{meta}{author}=$value;

+               if (exists $params{sortas}) {
+                       $pagestate{$page}{meta}{authorsort}=$params{sortas};
+               }
+               else {
+                       delete $pagestate{$page}{meta}{authorsort};
+               }

                # fallthorough
        }
        elsif ($key eq 'authorurl') {
                # fallthorough
        }
        elsif ($key eq 'authorurl') {


@@ -288,14 +299,31 @@ sub pagetemplate (@) {
        }
 }
 
        }
 }
 

-sub titlesort {
-       my $key = $pagestate{$_[0]}{meta}{titlesort};
+sub get_sort_key {
+       my $page = shift;
+       my $meta = shift;

 
 

-       if (defined $key) {
-               return $key;
-       }
+       # e.g. titlesort (also makes sense for author)
+       my $key = $pagestate{$page}{meta}{$meta . "sort"};
+       return $key if defined $key;
+
+       # e.g. title
+       $key = $pagestate{$page}{meta}{$meta};
+       return $key if defined $key;

 
 

-       return pagetitle(IkiWiki::basename($_[0]));
+       # fall back to closer-to-core things
+       if ($meta eq 'title') {
+               return pagetitle(IkiWiki::basename($page));
+       }
+       elsif ($meta eq 'date') {
+               return $IkiWiki::pagectime{$page};
+       }
+       elsif ($meta eq 'updated') {
+               return $IkiWiki::pagemtime{$page};
+       }
+       else {
+               return '';
+       }

 }
 
 sub match {
 }
 
 sub match {


@@ -350,10 +378,25 @@ sub match_copyright ($$;@) {
 
 package IkiWiki::SortSpec;
 
 
 package IkiWiki::SortSpec;
 

+sub cmp_meta {
+       my $meta = shift;
+       error(gettext("sort=meta requires a parameter")) unless defined $meta;
+
+       if ($meta eq 'updated' || $meta eq 'date') {
+               return IkiWiki::Plugin::meta::get_sort_key($a, $meta)
+                       <=>
+                       IkiWiki::Plugin::meta::get_sort_key($b, $meta);
+       }
+
+       return IkiWiki::Plugin::meta::get_sort_key($a, $meta)
+               cmp
+               IkiWiki::Plugin::meta::get_sort_key($b, $meta);
+}
+
+# A prototype of how sort=title could behave in 4.0 or something

 sub cmp_meta_title {
 sub cmp_meta_title {

-       IkiWiki::Plugin::meta::titlesort($_[0])
-       cmp
-       IkiWiki::Plugin::meta::titlesort($_[1])
+       $_[0] = 'title';
+       return cmp_meta(@_);

 }
 
 1
 }
 
 1