web commit by joey

[ikiwiki.git] / doc / security.mdwn

diff --git a/doc/security.mdwn b/doc/security.mdwn
index 278bad024101bae6babb487db7e22cc09583c7d9..ce4c6f718202581e3dc3871d8b4a64cead0c82b0 100644 (file)
--- a/doc/security.mdwn
+++ b/doc/security.mdwn
@@ -69,6 +69,14 @@ Setup files are not safe to keep in subversion with the rest of the wiki.
 Just don't do it. [[ikiwiki.setup]] is *not* used as the setup file for
 this wiki, BTW.
 
+## svn commit logs
+
+Anyone with svn commit access can forge "web commit from foo" and make it appeat on [[RecentChanges]] like foo committed. One way to avoid this would be to limit web commits to those done by a certian user.
+
+It's actually possible to force a whole series of svn commits to appear to have come just before yours, by forging svn log output. This could be guarded against somewhat by revision number scanning, since the forged revisions would duplicate the numbers of unforged ones. Or subversion could fix svn log to indent commit messages, which would make such forgery impossible..
+
+ikiwiki escapes any html in svn commit logs to prevent other mischief.
+
 ----
 
 # Hopefully non-holes
@@ -131,7 +139,7 @@ security holes breed. It needs a test suite at the very least.
 ## cgi password security
 
 Login to the wiki involves sending a password in cleartext over the net.
-Cracking the password only allows editing the moo as that user though.
+Cracking the password only allows editing the wiki as that user though.
 If you care, you can use https, I suppose.
 
 ## CGI::Session security