uh oh, this affects link deps

[ikiwiki.git] / doc / bugs / map_fails_to_close_ul_element_for_empty_list.mdwn

diff --git a/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn b/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn
index 940e56cab4651a26b815ee129b0477be67ed426d..ad0f506f208d1a5f81c272726f33e785cabae325 100644 (file)
--- a/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn
+++ b/doc/bugs/map_fails_to_close_ul_element_for_empty_list.mdwn
@@ -51,3 +51,43 @@ Patch:
 >>> The patch in [[map/discussion|plugins/map/discussion]] has the same
 >>> problem, but does suggest a simpler approach to solving it (bail out
 >>> early if the map has no items at all). --[[smcv]]
+
+>>>> Thanks for pointing out the problem. I guess this patch should solve it.
+>>>> --[[harishcm]]
+
+>>>>> Well, I suppose that's certainly a minimal patch for this bug :-)
+>>>>> I'm not the IkiWiki maintainer, but if I was, I'd apply it, so I've put
+>>>>> it in a git branch for Joey's convenience. Joey, Jon: any opinion?
+>>>>>
+>>>>> If you want to be credited for this patch under a name other than
+>>>>> "harishcm" (e.g. your real name), let me know and I'll amend the branch.
+>>>>> (Or, make a git branch of your own and replace the reference just below,
+>>>>> if you prefer.) --[[smcv]]
+
+>>>>>> The current arrangement looks fine to me. Thanks. --[[harishcm]]
+
+> [[merged|done]] --[[Joey]] 
+
+Patch:
+
+    --- /usr/local/share/perl/5.8.8/IkiWiki/Plugin/map.pm
+    +++ map.pm
+    @@ -80,7 +80,17 @@
+       my $indent=0;
+       my $openli=0;
+       my $addparent="";
+    -  my $map = "<div class='map'>\n<ul>\n";
+    +  my $map = "<div class='map'>\n";
+    +
+    +  # Return empty div if %mapitems is empty
+    +  if (!scalar(keys %mapitems)) {
+    +          $map .= "</div>\n";
+    +          return $map; 
+    +  } 
+    +  else { # continue populating $map
+    +          $map .= "<ul>\n";
+    +  }
+    +
+       foreach my $item (sort keys %mapitems) {
+               my @linktext = (length $mapitems{$item} ? (linktext => $mapitems{$item}) : ());
+               $item=~s/^\Q$common_prefix\E\///