]> sipb.mit.edu Git - ikiwiki.git/blobdiff - IkiWiki/Plugin/editpage.pm
editpage: Avoid storing accidental state changes when previewing pages.
[ikiwiki.git] / IkiWiki / Plugin / editpage.pm
index af2c5ff4e5e9558ac3ee4d337637ef796235c69f..3d731d399f34e9b857616135574727b24abb1757 100644 (file)
@@ -170,10 +170,8 @@ sub cgi_editpage ($$) {
                $previewing=1;
 
                my $new=not exists $pagesources{$page};
                $previewing=1;
 
                my $new=not exists $pagesources{$page};
-               if ($new) {
-                       # temporarily record its type
-                       $pagesources{$page}=$page.".".$type;
-               }
+               # temporarily record its type
+               $pagesources{$page}=$page.".".$type if $new;
                my %wasrendered=map { $_ => 1 } @{$renderedfiles{$page}};
 
                my $content=$form->field('editcontent');
                my %wasrendered=map { $_ => 1 } @{$renderedfiles{$page}};
 
                my $content=$form->field('editcontent');
@@ -198,18 +196,17 @@ sub cgi_editpage ($$) {
                });
                $form->tmpl_param("page_preview", $preview);
                
                });
                $form->tmpl_param("page_preview", $preview);
                
-               if ($new) {
-                       delete $pagesources{$page};
-               }
-
                # Previewing may have created files on disk.
                # Keep a list of these to be deleted later.
                my %previews = map { $_ => 1 } @{$wikistate{editpage}{previews}};
                foreach my $f (@{$renderedfiles{$page}}) {
                        $previews{$f}=1 unless $wasrendered{$f};
                }
                # Previewing may have created files on disk.
                # Keep a list of these to be deleted later.
                my %previews = map { $_ => 1 } @{$wikistate{editpage}{previews}};
                foreach my $f (@{$renderedfiles{$page}}) {
                        $previews{$f}=1 unless $wasrendered{$f};
                }
+
+               # Throw out any other state changes made during previewing,
+               # and save the previews list.
+               loadindex();
                @{$wikistate{editpage}{previews}} = keys %previews;
                @{$wikistate{editpage}{previews}} = keys %previews;
-               $renderedfiles{$page}=[keys %wasrendered];
                saveindex();
        }
        elsif ($form->submitted eq "Save Page") {
                saveindex();
        }
        elsif ($form->submitted eq "Save Page") {