Asking for a new mirrorlist branch review.

[ikiwiki.git] / doc / todo / mirrorlist_with_per-mirror_usedirs_settings.mdwn

diff --git a/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn b/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn
index 484f85cbb6bce24c15c1cff650ecdc96f6db7040..31e62f44ccfbb02d9e32bad97ee00854edbf94ba 100644 (file)
--- a/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn
+++ b/doc/todo/mirrorlist_with_per-mirror_usedirs_settings.mdwn
@@ -27,6 +27,8 @@ and decided this time it was really needed to implement this feature.
 
 >> (I'm not an ikiwiki committer, opinions may vary.)
 >>
 
 >> (I'm not an ikiwiki committer, opinions may vary.)
 >>

+>>> In my opinion, you're an ikiwiki committer! --[[Joey]]
+>>

 >> This would be easier to review if there weren't a million merges from
 >> master; perhaps either leave a branch as-is, or rebase it, or merge
 >> only at "significant" times like after a release?
 >> This would be easier to review if there weren't a million merges from
 >> master; perhaps either leave a branch as-is, or rebase it, or merge
 >> only at "significant" times like after a release?


@@ -48,3 +50,29 @@ and decided this time it was really needed to implement this feature.
 >>      $untainted{$key} = possibly_foolish_untaint($tainted->{key});
 >>
 >> --[[smcv]]
 >>      $untainted{$key} = possibly_foolish_untaint($tainted->{key});
 >>
 >> --[[smcv]]

+
+>>> You are fully right about the complex `$config` entries. I'll
+>>> convert this to use what you are suggesting, i.e. what we ended up
+>>> choosing for the `po_slave_languages` setting.
+>>>
+>>> About the merges in this branch: Joey told me once he did not care
+>>> about this; moreover the `--no-merges` git log option makes it
+>>> easy to filter these out. I'll try merging tagged releases only in
+>>> the future, though.
+>>>
+>>> --[[intrigeri]]
+
+>>>> FWIW, I don't care about merge commits etc because I review
+>>>> `git diff ...intrigeri/mirrorlist` -- and if I want to dig deeper
+>>>> into the why of some code, I'll probably checkout the branch and
+>>>> use git blame.
+>>>>
+>>>> I agree with what smcv said, my other concern though is that
+>>>> this is such an edge case, that supporting it just adds clutter.
+>>>> Have to wonder if it wouldn't perhaps be better to do something
+>>>> using the goto plugin and cgiurl, so that the mirror doesn't have
+>>>> to know about the configuration of the other mirror. --[[Joey]]
+
+>>>>> I have implemented something using the cgi + goto in my (history
+>>>>> rewrite warning) mirrorlist branch. Please review, please pull.
+>>>>> --[[intrigeri]]