fix removal of helf attachments

[ikiwiki.git] / IkiWiki / Plugin / attachment.pm

diff --git a/IkiWiki/Plugin/attachment.pm b/IkiWiki/Plugin/attachment.pm
index b7ea1f312793b1ea61e44c890c720b537f6d0a6b..c6f8891c226a8ece9d6891d850eff389e37a4b58 100644 (file)
--- a/IkiWiki/Plugin/attachment.pm
+++ b/IkiWiki/Plugin/attachment.pm
@@ -10,7 +10,7 @@ sub import {
        hook(type => "getsetup", id => "attachment", call => \&getsetup);
        hook(type => "checkconfig", id => "attachment", call => \&checkconfig);
        hook(type => "formbuilder_setup", id => "attachment", call => \&formbuilder_setup);
-       hook(type => "formbuilder", id => "attachment", call => \&formbuilder);
+       hook(type => "formbuilder", id => "attachment", call => \&formbuilder, last => 1);
        IkiWiki::loadplugin("filecheck");
 }
 
@@ -103,6 +103,12 @@ sub formbuilder_setup (@) {
                else {
                        $form->tmpl_param("attachments-class" => "toggleable-open");
                }
+               
+               # Save attachments in holding area before previewing so
+               # they can be seen in the preview.
+               if ($form->submitted eq "Preview") {
+                       attachments_save($form, $params{session});
+               }
        }
 }
 
@@ -148,9 +154,25 @@ sub formbuilder (@) {
 }
 
 sub attachment_holding_dir {
-       my $page=shift;
+       my $page=attachment_location(shift);
+
+       return $config{wikistatedir}."/attachments/".
+               IkiWiki::possibly_foolish_untaint(linkpage($page));
+}
 
-       return $config{wikistatedir}."/attachments/$page";
+sub remove_held_attachment {
+       my $attachment=shift;
+
+       my $f=attachment_holding_dir($attachment);
+       $f=~s/\/$//;
+       if (-f $f) {
+               require IkiWiki::Render;
+               IkiWiki::prune($f);
+               return 1;
+       }
+       else {
+               return 0;
+       }
 }
 
 # Stores the attachment in a holding area, not yet in the wiki proper.
@@ -178,11 +200,13 @@ sub attachment_store {
 
        $filename=IkiWiki::basename($filename);
        $filename=~s/.*\\+(.+)/$1/; # hello, windows
+       $filename=IkiWiki::possibly_foolish_untaint(linkpage($filename));
        
        # Check that the user is allowed to edit the attachment.
-       my $final_filename=linkpage(IkiWiki::possibly_foolish_untaint(
-               attachment_location($form->field('page')).
-               $filename));
+       my $final_filename=
+               linkpage(IkiWiki::possibly_foolish_untaint(
+                       attachment_location($form->field('page')))).
+               $filename;
        if (IkiWiki::file_pruned($final_filename)) {
                error(gettext("bad attachment filename"));
        }
@@ -212,8 +236,7 @@ sub attachment_store {
                        }
                }
                binmode($fh);
-               # Needed for fast_file_copy.
-               require IkiWiki::Render;
+               require IkiWiki::Render; 
                writefile($filename, $dest, undef, 1, sub {
                        IkiWiki::fast_file_copy($tempfile, $filename, $fh, @_);
                });
@@ -232,14 +255,15 @@ sub attachments_save {
                next unless -f $filename;
                my $dest=$config{srcdir}."/".
                        linkpage(IkiWiki::possibly_foolish_untaint(
-                               attachment_location($form->field('page')).
-                               $filename));
+                               attachment_location($form->field('page')))).
+                       IkiWiki::basename($filename);
                unlink($dest);
                rename($filename, $dest);
                push @attachments, $dest;
        }
        return unless @attachments;
-       rmdir($dir);
+       require IkiWiki::Render;
+       IkiWiki::prune($dir);
 
        # Check the attachments in and trigger a wiki refresh.
        if ($config{rcs}) {
@@ -271,11 +295,12 @@ sub attachment_list ($) {
        my $page=shift;
        my $loc=attachment_location($page);
 
-       my @ret;
+       # attachments already in the wiki
+       my %attachments;
        foreach my $f (values %pagesources) {
                if (! defined pagetype($f) &&
                    $f=~m/^\Q$loc\E[^\/]+$/) {
-                       push @ret, {
+                       $attachments{$f}={
                                "field-select" => '<input type="checkbox" name="attachment_select" value="'.$f.'" />',
                                link => htmllink($page, $page, $f, noimageinline => 1),
                                size => IkiWiki::Plugin::filecheck::humansize((stat($f))[7]),
@@ -284,10 +309,26 @@ sub attachment_list ($) {
                        };
                }
        }
+       
+       # attachments in holding directory
+       my $dir=attachment_holding_dir($page);
+       my $heldmsg=gettext("this attachment is not yet saved");
+       foreach my $file (glob("$dir/*")) {
+               my $mtime=(stat($file))[9];
+               my $f=IkiWiki::basename($file);
+               $attachments{$f}={
+                       "field-select" => '<input type="checkbox" name="attachment_select" value="'.$f.'" />',
+                       link => "<span title=\"$heldmsg\">$f</span>",
+                       size => IkiWiki::Plugin::filecheck::humansize((stat($file))[7]),
+                       mtime => displaytime($mtime),
+                       mtime_raw => $mtime,
+               }
+       }
 
        # Sort newer attachments to the top of the list, so a newly-added
        # attachment appears just before the form used to add it.
-       return sort { $b->{mtime_raw} <=> $a->{mtime_raw} || $a->{link} cmp $b->{link} } @ret;
+       return sort { $b->{mtime_raw} <=> $a->{mtime_raw} || $a->{link} cmp $b->{link} }
+               values %attachments;
 }
 
 1