ikiwiki-mass-rebuild: Don't trust $! when setting $)

A better fix, just check that what $) returns is what it was asked to set,
and ignore $! entirely.

diff --git a/debian/changelog b/debian/changelog
index 788d4b44ae889502e112b6a51bdb905bb90366b4..1f24f75308e91e9eabc10f14f71217fd7555cf74 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,7 +1,7 @@
 ikiwiki (2.49) UNRELEASED; urgency=low
 
   * haiku: Generate valid xhtml.
 ikiwiki (2.49) UNRELEASED; urgency=low
 
   * haiku: Generate valid xhtml.

-  * ikiwiki-mass-rebuild: under $! before setting $) to avoid strange errno issue
+  * ikiwiki-mass-rebuild: Don't trust $! when setting $)

 
  -- Joey Hess <joeyh@debian.org>  Fri, 30 May 2008 19:08:54 -0400
 
 
  -- Joey Hess <joeyh@debian.org>  Fri, 30 May 2008 19:08:54 -0400
 

diff --git a/ikiwiki-mass-rebuild b/ikiwiki-mass-rebuild
index 0057beb4f1735f957045adb9ccb1f2893a89bbdc..b40eb0b3b435b95da7d6675904da3e2804684431 100755 (executable)
--- a/ikiwiki-mass-rebuild
+++ b/ikiwiki-mass-rebuild
@@ -34,9 +34,7 @@ sub processline {
        if (! $pid) {
                my ($uuid, $ugid) = (getpwnam($user))[2, 3];
                my $grouplist=join(" ", $ugid, $ugid, supplemental_groups($user));
        if (! $pid) {
                my ($uuid, $ugid) = (getpwnam($user))[2, 3];
                my $grouplist=join(" ", $ugid, $ugid, supplemental_groups($user));

-               undef $!;
-               $)=$grouplist;
-               if ($!) {
+               if (($)=$grouplist) ne $grouplist) {

                        die "failed to set egid $grouplist: $!";
                }
                $(=$ugid;
                        die "failed to set egid $grouplist: $!";
                }
                $(=$ugid;