1 Known issues with the [[plugins/comments]] plugin:
3 * There is some common code cargo-culted from other plugins (notably inline and editpage) which
4 should probably be shared
6 > Actually, there's less of this now than there used to be - a lot of simple
7 > things that were shared have become unshareable as they became more
10 * Previews always say "unknown IP address"
12 * Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID
14 > Done in my comments git branch --[[smcv]]
16 > Not seeing it there, which branch? --[[Joey]]
18 >> Bah, git push --all is not the default... 'comments' branch now (I've also rebased it).
19 >> Sorry, I'm on mobile Internet at the moment... --[[smcv]]
21 * The default template should have a (?) icon next to unauthenticated users (with the IP address
22 as title) and an OpenID icon next to OpenIDs
24 > Done in my comments git branch, at least as a mockup (using the (?),
25 > {x} and {*} smileys for anonymous, OpenID and login respectively).
28 >> I've improved this to use independent icons from the wikiicons
29 >> directory (untested!) --[[smcv]]
31 * Should the comments be visually set off more from the page above?
32 Rather than just a horizontal rule, I'm thinking put the comments
33 in a box like is used for inlined pages.
35 > I did put them in a box in the CSS... I agree the default template
36 > could do with visual improvement though. --[[smcv]]
38 * Instead of just a link to add a comment, it could have a form to enter
39 the title, similar to the form for adding a new blog post.
41 > I'm not sure this is so useful? On Livejournal titles are allowed on
42 > comments, but very rarely used (and indeed usually not very useful);
43 > it's hard enough to get some people to title their blog posts :-)
46 * If a spammer posts a comment, it is either impossible or hard to clean
47 up via the web. Would be nice to have some kind of link on the comment
48 that allows trusted users to remove it (using the remove plugin of
51 > Won't the remove plugin refuse to remove internal pages? This would be
52 > a good feature to have, though. --[[smcv]]
54 * One can use inline to set up a feed of all comments posted to any page.
55 Using template=comment they are displayed right. Only problem
56 is there is no indication in that template of what page each comment in the
57 feed is a comment on. So, if a comment is inlined into a different page,
58 I think it should show a link back to the page commented on.
59 (BTW, the rss feed in this situation seems ok; there the link element
60 points back to the parent page.
64 * It would be useful to have a pagespec that always matches all comments on
65 pages matching a glob. Something like `comment(blog/*)`.
66 Perhaps postcomment could also be folded into this? Then the pagespec
67 would match both existing comments, as well as new comments that are
70 > Please see [[plugins/comments/discussion]]. If I've convinced you that
71 > internal pages are the way forward, then sure, we can do that, because
72 > people who can comment still won't be able to edit others' comments
73 > (one of my goals is that commenters can't put words into each other's
76 > On the other hand, if you still want me to switch this plugin to "real"
77 > pages, or if internal pages might become editable in future, then
78 > configuring lockedit/anonok so a user X can add comments to blog pages
79 > would also let X edit/delete comments on blog pages (including those
80 > written by others) in arbitrary ways, which doesn't seem good. --[[smcv]]
82 > I had a look at implementing comment() and fell afoul of
83 > some optimisations that assume only internal() will be used to match
84 > internal pages. So probably this isn't worth doing. --[[Joey]]
86 * One of Joey's commit messages says "Not ideal, it would be nicer to jump to
87 the actual comment posted, but no anchor is available". In fact there is
88 an anchor - the `\[[_comment]]` preprocessing wraps the comment in a <div>
89 with id="comment_123" or something. I'll fix this, unless Joey gets there
94 * Now that inline has some comments-specific functionality anyway, it would
95 be good to output '<link rel="comments">' in Atom and the equivalent in RSS.